From: Mike Rapoport <rppt@kernel•org>
To: Bartosz Golaszewski <brgl@bgdev•pl>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux•intel.com>,
"Sumit Semwal" <sumit.semwal@linaro•org>,
"Gustavo Padovan" <gustavo@padovan•org>,
"Christian König" <christian.koenig@amd•com>,
"Mauro Carvalho Chehab" <mchehab@kernel•org>,
"Borislav Petkov" <bp@alien8•de>,
"Tony Luck" <tony.luck@intel•com>,
"James Morse" <james.morse@arm•com>,
"Robert Richter" <rric@kernel•org>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"David Airlie" <airlied@linux•ie>,
"Daniel Vetter" <daniel@ffwll•ch>,
"Alexander Shishkin" <alexander.shishkin@linux•intel.com>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Michael S . Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Christoph Lameter" <cl@linux•com>,
"Pekka Enberg" <penberg@kernel•org>,
"David Rientjes" <rientjes@google•com>,
"Joonsoo Kim" <iamjoonsoo.kim@lge•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Jaroslav Kysela" <perex@perex•cz>,
"Takashi Iwai" <tiwai@suse•com>,
linux-media@vger•kernel.org, dri-devel@lists•freedesktop.org,
linaro-mm-sig@lists•linaro.org, linux-kernel@vger•kernel.org,
linux-edac@vger•kernel.org, linux-gpio@vger•kernel.org,
kvm@vger•kernel.org, virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, linux-mm@kvack•org,
alsa-devel@alsa-project•org,
"Bartosz Golaszewski" <bgolaszewski@baylibre•com>
Subject: Re: [PATCH 1/8] mm: slab: provide krealloc_array()
Date: Wed, 28 Oct 2020 10:47:03 +0200 [thread overview]
Message-ID: <20201028084703.GC1428094@kernel.org> (raw)
In-Reply-To: <20201027121725.24660-2-brgl@bgdev.pl>
On Tue, Oct 27, 2020 at 01:17:18PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre•com>
>
> When allocating an array of elements, users should check for
> multiplication overflow or preferably use one of the provided helpers
> like: kmalloc_array().
>
> There's no krealloc_array() counterpart but there are many users who use
> regular krealloc() to reallocate arrays. Let's provide an actual
> krealloc_array() implementation.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>
> ---
> include/linux/slab.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index dd6897f62010..0e6683affee7 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -592,6 +592,17 @@ static inline void *kmalloc_array(size_t n, size_t size, gfp_t flags)
> return __kmalloc(bytes, flags);
> }
>
Can you please add kernel-doc here and a word or two about this function
to Documentation/core-api/memory-allocation.rst?
> +static __must_check inline void *
> +krealloc_array(void *p, size_t new_n, size_t new_size, gfp_t flags)
> +{
> + size_t bytes;
> +
> + if (unlikely(check_mul_overflow(new_n, new_size, &bytes)))
> + return NULL;
> +
> + return krealloc(p, bytes, flags);
> +}
> +
> /**
> * kcalloc - allocate memory for an array. The memory is set to zero.
> * @n: number of elements.
> --
> 2.29.1
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-10-28 22:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 12:17 [PATCH 0/8] slab: provide and use krealloc_array() Bartosz Golaszewski
2020-10-27 12:17 ` [PATCH 1/8] mm: slab: provide krealloc_array() Bartosz Golaszewski
2020-10-27 18:20 ` Vlastimil Babka
2020-10-28 8:47 ` Mike Rapoport [this message]
2020-10-27 12:17 ` [PATCH 2/8] ALSA: pcm: use krealloc_array() Bartosz Golaszewski
2020-10-27 12:39 ` Takashi Iwai
2020-10-27 12:17 ` [PATCH 3/8] vhost: vringh: " Bartosz Golaszewski
2020-10-27 15:28 ` Michael S. Tsirkin
2020-10-27 16:50 ` Joe Perches
2020-10-27 16:58 ` Bartosz Golaszewski
2020-10-27 17:08 ` Joe Perches
2020-10-27 18:00 ` Bartosz Golaszewski
2020-10-27 12:17 ` [PATCH 4/8] pinctrl: " Bartosz Golaszewski
2020-10-27 12:17 ` [PATCH 5/8] edac: ghes: " Bartosz Golaszewski
2020-10-27 18:25 ` Borislav Petkov
2020-10-27 12:17 ` [PATCH 6/8] drm: atomic: " Bartosz Golaszewski
2020-10-27 19:19 ` Daniel Vetter
2020-10-27 12:17 ` [PATCH 7/8] hwtracing: intel: " Bartosz Golaszewski
2020-10-27 12:17 ` [PATCH 8/8] dma-buf: " Bartosz Golaszewski
2020-10-27 12:21 ` Christian König
2020-11-05 10:52 ` [PATCH 0/8] slab: provide and " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028084703.GC1428094@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brgl@bgdev$(echo .)pl \
--cc=christian.koenig@amd$(echo .)com \
--cc=cl@linux$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gustavo@padovan$(echo .)org \
--cc=iamjoonsoo.kim@lge$(echo .)com \
--cc=james.morse@arm$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-edac@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mchehab@kernel$(echo .)org \
--cc=mripard@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=penberg@kernel$(echo .)org \
--cc=perex@perex$(echo .)cz \
--cc=rientjes@google$(echo .)com \
--cc=rric@kernel$(echo .)org \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=tiwai@suse$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox