From: Andrew Lunn <andrew@lunn•ch>
To: Dominique Martinet <asmadeus@codewreck•org>
Cc: netdev <netdev@vger•kernel.org>,
Eric Van Hensbergen <ericvh@gmail•com>,
Latchesar Ionkov <lucho@ionkov•net>,
v9fs-developer@lists•sourceforge.net
Subject: Re: [PATCH net-next] net: 9p: Fix kerneldoc warnings of missing parameters etc
Date: Sun, 1 Nov 2020 16:54:05 +0100 [thread overview]
Message-ID: <20201101155405.GA1109407@lunn.ch> (raw)
In-Reply-To: <20201031205813.GA624@nautica>
On Sat, Oct 31, 2020 at 09:58:13PM +0100, Dominique Martinet wrote:
> Andrew Lunn wrote on Sat, Oct 31, 2020:
> > net/9p/client.c:420: warning: Function parameter or member 'c' not described in 'p9_client_cb'
> > net/9p/client.c:420: warning: Function parameter or member 'req' not described in 'p9_client_cb'
> > net/9p/client.c:420: warning: Function parameter or member 'status' not described in 'p9_client_cb'
> > net/9p/client.c:568: warning: Function parameter or member 'uidata' not described in 'p9_check_zc_errors'
> > net/9p/trans_common.c:23: warning: Function parameter or member 'nr_pages' not described in 'p9_release_pages'
> > net/9p/trans_common.c:23: warning: Function parameter or member 'pages' not described in 'p9_release_pages'
> > net/9p/trans_fd.c:132: warning: Function parameter or member 'rreq' not described in 'p9_conn'
> > net/9p/trans_fd.c:132: warning: Function parameter or member 'wreq' not described in 'p9_conn'
> > net/9p/trans_fd.c:56: warning: Function parameter or member 'privport' not described in 'p9_fd_opts'
> > net/9p/trans_rdma.c:113: warning: Function parameter or member 'cqe' not described in 'p9_rdma_context'
> > net/9p/trans_rdma.c:129: warning: Function parameter or member 'privport' not described in 'p9_rdma_opts'
> > net/9p/trans_virtio.c:215: warning: Function parameter or member 'limit' not described in 'pack_sg_list_p'
> > net/9p/trans_virtio.c:83: warning: Function parameter or member 'chan_list' not described in 'virtio_chan'
> > net/9p/trans_virtio.c:83: warning: Function parameter or member 'p9_max_pages' not described in 'virtio_chan'
> > net/9p/trans_virtio.c:83: warning: Function parameter or member 'ring_bufs_avail' not described in 'virtio_chan'
> > net/9p/trans_virtio.c:83: warning: Function parameter or member 'tag' not described in 'virtio_chan'
> > net/9p/trans_virtio.c:83: warning: Function parameter or member 'vc_wq' not described in 'virtio_chan'
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn•ch>
>
> Thanks, LGTM I'll take this for next cycle unless someone is grabbing
> these
Hi Dominique
I hope to turn on W=1 by default soon in most of /net. That patch is
likely to go to net-next.
What route do your patches normally take to Linus? Do you send a pull
request to net-next? Or straight to Linus?
If this patch is not in net-next, i cannot enable it for 9p. So
either:
1) I leave 9p without W=1, and there is a risk it gains new warnings
which nobody notices
2) I send the W=1 enablement for 9p to you, but it does nothing in
your tree because you don't have the rest of the patches. Any new
warnings will appear in next, assuming 9p is merged into next, i've
not checked that.
3) I expect there to be a stable branch with the base patches needed
for W=1 by default. You can pull that into your tree, along with a
patch to actually enable it in 9p. You then get to know about new
warnings.
4) Jakub takes this patch into net-next, and i can then enable W=1 in
9p along with all the other sub-directories. We will get to know
about new warnings in net-next, and next, but not in your tree.
Andrew
next prev parent reply other threads:[~2020-11-01 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 18:26 [PATCH net-next] net: 9p: Fix kerneldoc warnings of missing parameters etc Andrew Lunn
2020-10-31 20:58 ` Dominique Martinet
2020-11-01 15:54 ` Andrew Lunn [this message]
2020-11-01 16:08 ` Dominique Martinet
2020-11-02 20:27 ` Jakub Kicinski
2020-11-02 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101155405.GA1109407@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=asmadeus@codewreck$(echo .)org \
--cc=ericvh@gmail$(echo .)com \
--cc=lucho@ionkov$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=v9fs-developer@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox