Subject: Re: [PATCH\ net] rtw88: fix fw dump support detection

From: Kalle Valo <[email-masked]>
Date: Mon, 2 Nov 2020 18:13:03 +0000 (UTC)

Arnd Bergmann <[email-masked]> wrote:

> From: Arnd Bergmann <[email-masked]>
> 
> clang points out a useless check that was recently added:
> 
> drivers/net/wireless/realtek/rtw88/fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true' [-Wpointer-bool-conversion]
>         if (!rtwdev->chip->fw_fifo_addr) {
>             ~~~~~~~~~~~~~~~^~~~~~~~~~~~
> 
> Apparently this was meant to check the contents of the array
> rather than the address, so check it accordingly.
> 
> Fixes: 0fbc2f0f34cc ("rtw88: add dump firmware fifo support")
> Signed-off-by: Arnd Bergmann <[email-masked]>
> Reviewed-by: Nathan Chancellor <[email-masked]>

I'll take Tom's patch as it was first.

Patch set to Superseded.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/[email-masked]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches