Subject: Re: [PATCH] compiler-clang: remove version check for BPF Tracing

From: Jarkko Sakkinen <[email-masked]>
Date: Wed, 4 Nov 2020 22:33:39 +0200

On Wed, Nov 04, 2020 at 11:10:51AM -0800, Nick Desaulniers wrote:
> bpftrace parses the kernel headers and uses Clang under the hood. Remove
> the version check when __BPF_TRACING__ is defined (as bpftrace does) so
> that this tool can continue to parse kernel headers, even with older
> clang sources.
> 
> Cc: <[email-masked]>
> Fixes: commit 1f7a44f63e6c ("compiler-clang: add build check for clang 10.0.1")
> Reported-by: Chen Yu <[email-masked]>
> Reported-by: Jarkko Sakkinen <[email-masked]>
> Signed-off-by: Nick Desaulniers <[email-masked]>
> ---

Thank you, resolved my issue.

Acked-by: Jarkko Sakkinen <[email-masked]>
Tested-by: Jarkko Sakkinen <[email-masked]>

>  include/linux/compiler-clang.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
> index dd7233c48bf3..98cff1b4b088 100644
> --- a/include/linux/compiler-clang.h
> +++ b/include/linux/compiler-clang.h
> @@ -8,8 +8,10 @@
>  		     + __clang_patchlevel__)
>  
>  #if CLANG_VERSION < 100001
> +#ifndef __BPF_TRACING__
>  # error Sorry, your version of Clang is too old - please use 10.0.1 or newer.
>  #endif
> +#endif
>  
>  /* Compiler specific definitions for Clang compiler */
>  
> -- 
> 2.29.1.341.ge80a0c044ae-goog
> 
> 

/Jarkko