Subject: Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement

From: Pablo Neira Ayuso <[email-masked]>
Date: Mon, 16 Nov 2020 10:26:48 +0100

Hi,

Thanks for catching up this.

On Sun, Nov 15, 2020 at 07:42:03PM -0800, Randy Dunlap wrote:
> Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
> by selecting NF_REJECT_IPV4, which provides the missing symbols.
> 
> ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
> ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
> 
> Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
> Reported-by: kernel test robot <[email-masked]>
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc: kernel test robot <[email-masked]>
> Cc: Jose M. Guisado Gomez <[email-masked]>
> Cc: Pablo Neira Ayuso <[email-masked]>
> Cc: Jozsef Kadlecsik <[email-masked]>
> Cc: Florian Westphal <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: Jakub Kicinski <[email-masked]>
> ---
>  net/bridge/netfilter/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
> +++ linux-next-20201113/net/bridge/netfilter/Kconfig
> @@ -18,6 +18,7 @@ config NFT_BRIDGE_META
>  config NFT_BRIDGE_REJECT
>  	tristate "Netfilter nf_tables bridge reject support"
>  	depends on NFT_REJECT
> +	depends on NF_REJECT_IPV4

I can update the patch here before applying to add:

        depends on NF_REJECT_IPV6

as well. It seems both dependencies (IPv4 and IPv6) are missing.

Thanks.

>  	help
>  	  Add support to reject packets.
>