Subject: Re: [PATCH 06/11] net: dsa: microchip: ksz8795: use phy_port_cnt where possible

From: Andrew Lunn <[email-masked]>
Date: Thu, 19 Nov 2020 01:29:15 +0100

>  	case BR_STATE_DISABLED:
>  		data |= PORT_LEARN_DISABLE;
> -		if (port < SWITCH_PORT_NUM)
> +		if (port < dev->phy_port_cnt)
>  			member = 0;
>  		break;

So this, unlike all the other patches so far, is not obviously
correct. What exactly does phy_port_cnt mean? Can there be ports
without PHYs? What if the PHYs are external? You still need to be able
to change the STP state of such ports.

Andrew