From: Sam Ravnborg <sam@ravnborg•org>
To: James Bottomley <James.Bottomley@hansenpartnership•com>
Cc: Kees Cook <keescook@chromium•org>,
Jakub Kicinski <kuba@kernel•org>,
alsa-devel@alsa-project•org,
linux-atm-general@lists•sourceforge.net,
reiserfs-devel@vger•kernel.org, linux-iio@vger•kernel.org,
linux-wireless@vger•kernel.org, linux-fbdev@vger•kernel.org,
dri-devel@lists•freedesktop.org, linux-kernel@vger•kernel.org,
Nathan Chancellor <natechancellor@gmail•com>,
linux-ide@vger•kernel.org, dm-devel@redhat•com,
keyrings@vger•kernel.org, linux-mtd@lists•infradead.org,
GR-everest-linux-l2@marvell•com, wcn36xx@lists•infradead.org,
samba-technical@lists•samba.org, linux-i3c@lists•infradead.org,
linux1394-devel@lists•sourceforge.net,
linux-afs@lists•infradead.org,
usb-storage@lists•one-eyed-alien.net, drbd-dev@lists•linbit.com,
devel@driverdev•osuosl.org, linux-cifs@vger•kernel.org,
rds-devel@oss•oracle.com,
Nick Desaulniers <ndesaulniers@google•com>,
linux-scsi@vger•kernel.org, linux-rdma@vger•kernel.org,
oss-drivers@netronome•com, bridge@lists•linux-foundation.org,
linux-security-module@vger•kernel.org,
amd-gfx@lists•freedesktop.org,
linux-stm32@st-md-mailman•stormreply.com,
cluster-devel@redhat•com, linux-acpi@vger•kernel.org,
coreteam@netfilter•org, intel-wired-lan@lists•osuosl.org,
linux-input@vger•kernel.org, Miguel Ojeda <ojeda@kernel•org>,
tipc-discussion@lists•sourceforge.net,
linux-ext4@vger•kernel.org, linux-media@vger•kernel.org,
linux-watchdog@vger•kernel.org, selinux@vger•kernel.org,
linux-arm-msm@vger•kernel.org, intel-gfx@lists•freedesktop.org,
linux-geode@lists•infradead.org, linux-can@vger•kernel.org,
linux-block@vger•kernel.org, linux-gpio@vger•kernel.org,
op-tee@lists•trustedfirmware.org,
linux-mediatek@lists•infradead.org,
xen-devel@lists•xenproject.org, nouveau@lists•freedesktop.org,
linux-hams@vger•kernel.org, ceph-devel@vger•kernel.org,
virtualization@lists•linux-foundation.org,
target-devel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-hwmon@vger•kernel.org, x86@kernel•org,
linux-nfs@vger•kernel.org, GR-Linux-NIC-Dev@marvell•com,
linux-mm@kvack•org, netdev@vger•kernel.org,
linux-decnet-user@lists•sourceforge.net,
linux-mmc@vger•kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
linux-renesas-soc@vger•kernel.org, linux-sctp@vger•kernel.org,
linux-usb@vger•kernel.org, netfilter-devel@vger•kernel.org,
linux-crypto@vger•kernel.org, patches@opensource•cirrus.com,
Joe Perches <joe@perches•com>,
linux-integrity@vger•kernel.org, linux-hardening@vger•kernel.org
Subject: Re: [PATCH 000/141] Fix fall-through warnings for Clang
Date: Sun, 22 Nov 2020 23:10:40 +0100 [thread overview]
Message-ID: <20201122221040.GD566387@ravnborg.org> (raw)
In-Reply-To: <9b57fd4914b46f38d54087d75e072d6e947cb56d.camel@HansenPartnership.com>
Hi James.
> > > If none of the 140 patches here fix a real bug, and there is no
> > > change to machine code then it sounds to me like a W=2 kind of a
> > > warning.
> >
> > FWIW, this series has found at least one bug so far:
> > https://lore.kernel.org/lkml/CAFCwf11izHF=g1mGry1fE5kvFFFrxzhPSM6qKAO8gxSp=Kr_CQ@mail.gmail.com/
>
>
> Well, it's a problem in an error leg, sure, but it's not a really
> compelling reason for a 141 patch series, is it? All that fixing this
> error will do is get the driver to print "oh dear there's a problem"
> under four more conditions than it previously did.
You are asking the wrong question here.
Yuo should ask how many hours could have been saved by all the bugs
people have been fighting with and then fixed *before* the code
hit the kernel at all.
My personal experience is that I, more than once, have had errors
related to a missing break in my code. So this warnings is IMO a win.
And if we are only ~100 patches to have it globally enabled then it is a
no-brainer in my book.
Sam
next prev parent reply other threads:[~2020-11-22 22:11 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 18:21 [PATCH 000/141] Fix fall-through warnings for Clang Gustavo A. R. Silva
2020-11-20 18:25 ` [PATCH 009/141] igb: " Gustavo A. R. Silva
2020-11-20 18:25 ` [PATCH 011/141] ipv4: " Gustavo A. R. Silva
2020-11-20 18:26 ` [PATCH 012/141] ixgbe: " Gustavo A. R. Silva
2020-11-20 18:26 ` [PATCH 015/141] netfilter: " Gustavo A. R. Silva
2020-11-20 22:47 ` Florian Westphal
2020-11-23 22:45 ` Gustavo A. R. Silva
2020-11-20 18:26 ` [PATCH 018/141] qed: " Gustavo A. R. Silva
2020-11-20 18:50 ` [EXT] " Igor Russkikh
2020-11-23 22:46 ` Gustavo A. R. Silva
2020-11-20 18:27 ` [PATCH 019/141] qlcnic: " Gustavo A. R. Silva
2020-11-20 18:27 ` [PATCH 025/141] bnxt_en: " Gustavo A. R. Silva
2020-11-20 18:28 ` [PATCH 029/141] e1000: " Gustavo A. R. Silva
2020-11-20 18:28 ` [PATCH 033/141] fm10k: " Gustavo A. R. Silva
2020-11-20 18:28 ` [PATCH 000/141] " Joe Perches
2020-11-20 19:02 ` Gustavo A. R. Silva
2020-11-20 18:29 ` [PATCH 036/141] ice: " Gustavo A. R. Silva
2020-11-20 18:30 ` [PATCH 039/141] ixgbevf: " Gustavo A. R. Silva
2020-11-20 18:30 ` [PATCH 042/141] net: 3c509: " Gustavo A. R. Silva
2021-03-04 22:50 ` Gustavo A. R. Silva
2020-11-20 18:31 ` [PATCH 043/141] net: cassini: " Gustavo A. R. Silva
2021-03-04 22:52 ` Gustavo A. R. Silva
2020-11-20 18:31 ` [PATCH 044/141] net/mlx4: " Gustavo A. R. Silva
2020-11-22 8:36 ` Tariq Toukan
2020-11-23 22:49 ` Gustavo A. R. Silva
2020-11-20 18:31 ` [PATCH 045/141] net: mscc: ocelot: " Gustavo A. R. Silva
2021-03-04 22:53 ` Gustavo A. R. Silva
2021-03-04 23:01 ` Vladimir Oltean
2021-03-05 19:22 ` Gustavo A. R. Silva
2020-11-20 18:31 ` [PATCH 046/141] netxen_nic: " Gustavo A. R. Silva
2020-11-20 18:31 ` [PATCH 047/141] nfp: " Gustavo A. R. Silva
2020-11-20 18:32 ` [PATCH 056/141] vxge: " Gustavo A. R. Silva
2020-11-20 18:33 ` [PATCH 065/141] airo: " Gustavo A. R. Silva
2020-12-08 8:08 ` Kalle Valo
2020-11-20 18:34 ` [PATCH 069/141] ath5k: " Gustavo A. R. Silva
2020-12-09 7:03 ` Kalle Valo
2020-11-20 18:34 ` [PATCH 070/141] atm: fore200e: " Gustavo A. R. Silva
2021-04-20 20:17 ` Gustavo A. R. Silva
2021-05-17 23:52 ` Gustavo A. R. Silva
2020-11-20 18:34 ` [PATCH 072/141] can: peak_usb: " Gustavo A. R. Silva
2020-11-21 13:17 ` Marc Kleine-Budde
2020-11-21 19:50 ` Joe Perches
2020-11-21 23:04 ` Marc Kleine-Budde
2020-11-22 2:46 ` Joe Perches
2020-11-20 18:34 ` [PATCH 073/141] carl9170: " Gustavo A. R. Silva
2020-11-20 18:34 ` [PATCH 074/141] cfg80211: " Gustavo A. R. Silva
2020-11-20 18:35 ` [PATCH 076/141] decnet: " Gustavo A. R. Silva
2021-03-04 22:54 ` Gustavo A. R. Silva
2020-11-20 18:36 ` [PATCH 091/141] iwlwifi: iwl-drv: " Gustavo A. R. Silva
2020-12-11 18:22 ` Kalle Valo
2020-11-20 18:36 ` [PATCH 093/141] mac80211: " Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 099/141] mt76: mt7615: " Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 105/141] net: ax25: " Gustavo A. R. Silva
2021-03-04 22:54 ` Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 106/141] net: bridge: " Gustavo A. R. Silva
2021-02-02 14:16 ` Nikolay Aleksandrov
2021-03-04 22:56 ` Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 107/141] net: core: " Gustavo A. R. Silva
2021-03-04 22:56 ` Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 108/141] netfilter: ipt_REJECT: " Gustavo A. R. Silva
2020-11-20 22:49 ` Florian Westphal
2020-11-24 14:37 ` Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 109/141] net: netrom: " Gustavo A. R. Silva
2020-11-30 12:51 ` Dan Carpenter
2020-11-20 18:38 ` [PATCH 110/141] net/packet: " Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 111/141] net: plip: " Gustavo A. R. Silva
2021-03-04 23:00 ` Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 112/141] net: rose: " Gustavo A. R. Silva
2021-03-04 23:00 ` Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 113/141] nl80211: " Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 115/141] rds: " Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 116/141] rt2x00: " Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 117/141] rtl8xxxu: " Gustavo A. R. Silva
2020-11-20 21:39 ` Jes Sorensen
2020-11-24 16:09 ` Gustavo A. R. Silva
2020-11-20 18:39 ` [PATCH 118/141] rtw88: " Gustavo A. R. Silva
2020-11-20 18:39 ` [PATCH 119/141] rxrpc: " Gustavo A. R. Silva
2020-11-20 18:39 ` [PATCH 125/141] sctp: " Gustavo A. R. Silva
2020-11-20 18:39 ` [PATCH 127/141] staging: qlge: " Gustavo A. R. Silva
2020-11-25 4:42 ` Benjamin Poirier
2020-11-30 12:55 ` Dan Carpenter
2020-11-20 18:40 ` [PATCH 129/141] SUNRPC: " Gustavo A. R. Silva
2020-11-20 18:40 ` [PATCH 130/141] tipc: " Gustavo A. R. Silva
2020-11-20 18:40 ` [PATCH 136/141] virtio_net: " Gustavo A. R. Silva
2020-11-20 18:40 ` [PATCH 137/141] wcn36xx: " Gustavo A. R. Silva
2020-11-20 18:41 ` [PATCH 139/141] xfrm: " Gustavo A. R. Silva
2020-11-20 18:41 ` [PATCH 140/141] zd1201: " Gustavo A. R. Silva
2020-11-20 18:53 ` [PATCH 000/141] " Jakub Kicinski
2020-11-20 19:04 ` Gustavo A. R. Silva
2020-11-20 19:30 ` Kees Cook
2020-11-20 19:51 ` Jakub Kicinski
2020-11-20 20:48 ` Kees Cook
2020-11-22 16:17 ` Kees Cook
2020-11-22 18:21 ` James Bottomley
2020-11-22 18:25 ` Joe Perches
2020-11-22 19:12 ` James Bottomley
2020-11-22 19:22 ` Joe Perches
2020-11-22 19:53 ` James Bottomley
2020-11-23 13:03 ` [Intel-wired-lan] " Gustavo A. R. Silva
2020-11-23 16:31 ` James Bottomley
2020-11-24 21:32 ` Kees Cook
2020-11-24 22:24 ` Finn Thain
2020-11-24 23:15 ` Miguel Ojeda
2020-11-24 23:53 ` Finn Thain
2020-11-25 1:05 ` Miguel Ojeda
2020-11-25 7:05 ` James Bottomley
2020-11-25 12:24 ` Nick Desaulniers
2020-11-25 21:33 ` Finn Thain
2020-11-25 22:09 ` Nick Desaulniers
2020-11-25 23:21 ` Finn Thain
2020-11-26 0:30 ` Finn Thain
[not found] ` <20201125082405.1d8c23dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2020-11-25 17:04 ` Miguel Ojeda
2020-11-25 22:09 ` Nick Desaulniers
2020-11-25 21:10 ` Kees Cook
2020-11-22 20:35 ` Miguel Ojeda
2020-11-22 22:36 ` James Bottomley
2020-11-23 14:19 ` Miguel Ojeda
2020-11-23 15:58 ` James Bottomley
2020-11-23 16:24 ` Rafael J. Wysocki
2020-11-23 16:32 ` Joe Perches
2020-11-23 18:56 ` Miguel Ojeda
2020-11-23 20:37 ` James Bottomley
2020-11-25 0:32 ` Miguel Ojeda
2020-11-25 22:44 ` Edward Cree
2020-11-26 14:53 ` Miguel Ojeda
2020-11-26 15:28 ` Geert Uytterhoeven
2020-11-26 16:18 ` Karol Herbst
2020-11-26 17:05 ` Miguel Ojeda
2020-11-25 10:38 ` Andy Shevchenko
2020-11-25 9:01 ` Sean Young
2020-11-22 22:54 ` Finn Thain
2020-11-22 23:04 ` James Bottomley
2020-11-23 14:05 ` Miguel Ojeda
2020-11-24 0:58 ` Finn Thain
2020-11-24 1:05 ` Joe Perches
2020-11-24 2:48 ` Finn Thain
2020-11-24 23:46 ` Miguel Ojeda
2020-11-22 22:10 ` Sam Ravnborg [this message]
2020-11-24 1:32 ` Nick Desaulniers
2020-11-24 21:25 ` Kees Cook
2020-11-25 23:02 ` Edward Cree
2020-12-01 14:08 ` Dan Carpenter
2020-12-01 14:04 ` Dan Carpenter
2020-11-20 22:21 ` Miguel Ojeda
2020-11-23 20:03 ` Jason Gunthorpe
2020-11-24 14:47 ` Gustavo A. R. Silva
[not found] ` <160616392671.21180.16517492185091399884.b4-ty@kernel.org>
2020-11-24 14:47 ` Gustavo A. R. Silva
2020-12-01 5:52 ` Martin K. Petersen
2020-12-01 8:20 ` Gustavo A. R. Silva
2020-12-08 4:52 ` (subset) " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122221040.GD566387@ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=GR-everest-linux-l2@marvell$(echo .)com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=cluster-devel@redhat$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=dm-devel@redhat$(echo .)com \
--cc=drbd-dev@lists$(echo .)linbit.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gustavoars@kernel$(echo .)org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=joe@perches$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=keyrings@vger$(echo .)kernel.org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-atm-general@lists$(echo .)sourceforge.net \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-cifs@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-decnet-user@lists$(echo .)sourceforge.net \
--cc=linux-ext4@vger$(echo .)kernel.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-geode@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-hams@vger$(echo .)kernel.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-i3c@lists$(echo .)infradead.org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-integrity@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux1394-devel@lists$(echo .)sourceforge.net \
--cc=natechancellor@gmail$(echo .)com \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=nouveau@lists$(echo .)freedesktop.org \
--cc=ojeda@kernel$(echo .)org \
--cc=op-tee@lists$(echo .)trustedfirmware.org \
--cc=oss-drivers@netronome$(echo .)com \
--cc=patches@opensource$(echo .)cirrus.com \
--cc=rds-devel@oss$(echo .)oracle.com \
--cc=reiserfs-devel@vger$(echo .)kernel.org \
--cc=samba-technical@lists$(echo .)samba.org \
--cc=selinux@vger$(echo .)kernel.org \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=usb-storage@lists$(echo .)one-eyed-alien.net \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=wcn36xx@lists$(echo .)infradead.org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox