From: Frederic Weisbecker <frederic@kernel•org>
To: Alex Belits <abelits@marvell•com>
Cc: "nitesh@redhat•com" <nitesh@redhat•com>,
Prasun Kapoor <pkapoor@marvell•com>,
"linux-api@vger•kernel.org" <linux-api@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"trix@redhat•com" <trix@redhat•com>,
"mingo@kernel•org" <mingo@kernel•org>,
"catalin.marinas@arm•com" <catalin.marinas@arm•com>,
"rostedt@goodmis•org" <rostedt@goodmis•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"peterx@redhat•com" <peterx@redhat•com>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"linux-arch@vger•kernel.org" <linux-arch@vger•kernel.org>,
"mtosatti@redhat•com" <mtosatti@redhat•com>,
"will@kernel•org" <will@kernel•org>,
"peterz@infradead•org" <peterz@infradead•org>,
"leon@sidebranch•com" <leon@sidebranch•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"pauld@redhat•com" <pauld@redhat•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus
Date: Mon, 23 Nov 2020 23:29:07 +0100 [thread overview]
Message-ID: <20201123222907.GC1751@lothringen> (raw)
In-Reply-To: <3236b13f42679031960c5605be20664e90e75223.camel@marvell.com>
On Mon, Nov 23, 2020 at 05:58:42PM +0000, Alex Belits wrote:
> From: Yuri Norov <ynorov@marvell•com>
>
> Make sure that kick_all_cpus_sync() does not call CPUs that are running
> isolated tasks.
>
> Signed-off-by: Yuri Norov <ynorov@marvell•com>
> [abelits@marvell•com: use safe task_isolation_cpumask() implementation]
> Signed-off-by: Alex Belits <abelits@marvell•com>
> ---
> kernel/smp.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index 4d17501433be..b2faecf58ed0 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -932,9 +932,21 @@ static void do_nothing(void *unused)
> */
> void kick_all_cpus_sync(void)
> {
> + struct cpumask mask;
> +
> /* Make sure the change is visible before we kick the cpus */
> smp_mb();
> - smp_call_function(do_nothing, NULL, 1);
> +
> + preempt_disable();
> +#ifdef CONFIG_TASK_ISOLATION
> + cpumask_clear(&mask);
> + task_isolation_cpumask(&mask);
> + cpumask_complement(&mask, &mask);
> +#else
> + cpumask_setall(&mask);
> +#endif
> + smp_call_function_many(&mask, do_nothing, NULL, 1);
> + preempt_enable();
Same comment about IPIs here.
> }
> EXPORT_SYMBOL_GPL(kick_all_cpus_sync);
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-11-23 22:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 17:42 [PATCH v5 0/9] "Task_isolation" mode Alex Belits
2020-11-23 17:56 ` [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function Alex Belits
2020-11-23 21:48 ` Thomas Gleixner
2020-11-23 17:56 ` [PATCH v5 2/9] task_isolation: vmstat: add vmstat_idle function Alex Belits
2020-11-23 21:49 ` Thomas Gleixner
2020-11-23 17:56 ` [PATCH v5 3/9] task_isolation: userspace hard isolation from kernel Alex Belits
2020-11-23 22:01 ` Thomas Gleixner
2020-11-23 17:57 ` [PATCH v5 4/9] task_isolation: Add task isolation hooks to arch-independent code Alex Belits
2020-11-23 22:31 ` Thomas Gleixner
2020-11-23 17:57 ` [PATCH v5 5/9] task_isolation: Add driver-specific hooks Alex Belits
2020-12-02 14:18 ` Mark Rutland
2020-12-04 0:43 ` [EXT] " Alex Belits
2020-11-23 17:58 ` [PATCH v5 6/9] task_isolation: arch/arm64: enable task isolation functionality Alex Belits
2020-12-02 13:59 ` Mark Rutland
2020-12-04 0:37 ` [EXT] " Alex Belits
2020-12-07 11:57 ` Mark Rutland
2020-11-23 17:58 ` [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Alex Belits
2020-11-23 22:13 ` Frederic Weisbecker
2020-11-23 22:35 ` Alex Belits
2020-11-23 22:36 ` Thomas Gleixner
2020-12-02 14:20 ` Mark Rutland
2020-12-04 0:54 ` [EXT] " Alex Belits
2020-12-07 11:58 ` Mark Rutland
2020-11-23 17:58 ` [PATCH v5 8/9] task_isolation: ringbuffer: don't interrupt CPUs running isolated tasks on buffer resize Alex Belits
2020-11-23 17:58 ` [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus Alex Belits
2020-11-23 22:29 ` Frederic Weisbecker [this message]
2020-11-23 22:39 ` [EXT] " Alex Belits
2020-11-23 23:21 ` Frederic Weisbecker
2020-11-25 3:20 ` Alex Belits
2021-01-22 15:00 ` Marcelo Tosatti
2020-11-24 16:36 ` [PATCH v5 0/9] "Task_isolation" mode Tom Rix
2020-11-24 17:40 ` [EXT] " Alex Belits
2020-12-02 14:02 ` Mark Rutland
2020-12-04 0:39 ` Alex Belits
2020-12-05 20:40 ` Pavel Machek
2020-12-05 23:25 ` Thomas Gleixner
2020-12-11 18:08 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123222907.GC1751@lothringen \
--to=frederic@kernel$(echo .)org \
--cc=abelits@marvell$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=leon@sidebranch$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mingo@kernel$(echo .)org \
--cc=mtosatti@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nitesh@redhat$(echo .)com \
--cc=pauld@redhat$(echo .)com \
--cc=peterx@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pkapoor@marvell$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=trix@redhat$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox