From: Andrew Lunn <andrew@lunn•ch>
To: Moshe Shemesh <moshe@nvidia•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
Moshe Shemesh <moshe@mellanox•com>,
"David S. Miller" <davem@davemloft•net>,
Adrian Pop <pop.adrian61@gmail•com>,
Michal Kubecek <mkubecek@suse•cz>,
netdev@vger•kernel.org,
Vladyslav Tarasiuk <vladyslavt@nvidia•com>,
Maxim Mikityanskiy <maximmi@nvidia•com>
Subject: Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type
Date: Fri, 27 Nov 2020 16:56:37 +0100 [thread overview]
Message-ID: <20201127155637.GS2073444@lunn.ch> (raw)
In-Reply-To: <6a9bbcb0-c0c4-92fe-f3c1-581408d1e7da@nvidia.com>
> OK, but if the caching system is checking one time netlink and one time
> ioctl, it means this cache should be in user space, or did you mean to have
> this cache in kernel ?
This is all in userspace, in the ethtool code.
> > > What about the global offset that we currently got when user doesn't specify
> > > a page, do you mean that this global offset goes through the optional and
> > > non optional pages that exist and skip the ones that are missing according
> > > to the specific EEPROM ?
> > ethtool -m|--dump-module-eeprom|--module-info devname [raw on|off] [hex on|off] [offset N] [length N]
> >
> > So you mean [offset N] [length N].
>
>
> Yes, that's the current options and we can either try coding new
> implementation for that or just call the current ioctl implementation. The
> new code can be triggered once options [bank N] and [Page N] are used.
You cannot rely on the ioctl being available. New drivers won't
implement it, if they have the netlink code. Drivers will convert from
get_module_info to whatever new ndo call you add for netlink.
> OK, if I got it right on current API [offset N] [length N] just call ioctl
> current implementation, while using the option [raw on] will call new
> implementation for new SFPs (CMIS 4). Also using [bank N] and [page N] will
> call new implementation for new SFPs.
Not just CMIS. All SFPs.
Andrew
next prev parent reply other threads:[~2020-11-27 15:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 9:19 [PATCH net-next v2 0/2] Add support for DSFP transceiver type Moshe Shemesh
2020-11-23 9:19 ` [PATCH net-next v2 1/2] ethtool: Add CMIS 4.0 module type to UAPI Moshe Shemesh
2020-11-23 22:40 ` Jesse Brandeburg
2020-11-25 10:41 ` Moshe Shemesh
2020-11-23 9:19 ` [PATCH net-next v2 2/2] net/mlx5e: Add DSFP EEPROM dump support to ethtool Moshe Shemesh
2020-11-24 1:14 ` [PATCH net-next v2 0/2] Add support for DSFP transceiver type Andrew Lunn
2020-11-24 21:16 ` Jakub Kicinski
2020-11-25 10:40 ` Moshe Shemesh
2020-11-25 14:18 ` Andrew Lunn
2020-11-26 14:23 ` Moshe Shemesh
2020-11-26 15:21 ` Andrew Lunn
2020-11-27 15:12 ` Moshe Shemesh
2020-11-27 15:56 ` Andrew Lunn [this message]
2020-12-29 10:23 ` Vladyslav Tarasiuk
2020-12-29 16:25 ` Andrew Lunn
2020-12-30 13:55 ` Vladyslav Tarasiuk
2020-12-30 15:36 ` Andrew Lunn
2021-01-04 15:24 ` Vladyslav Tarasiuk
2021-01-04 15:48 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127155637.GS2073444@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=maximmi@nvidia$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=moshe@mellanox$(echo .)com \
--cc=moshe@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pop.adrian61@gmail$(echo .)com \
--cc=vladyslavt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox