From: Andrew Lunn <andrew@lunn•ch>
To: Russell King <rmk+kernel@armlinux•org.uk>
Cc: "Heiner Kallweit" <hkallweit1@gmail•com>,
"Pali Rohár" <pali@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/2] net: sfp: relax bitrate-derived mode check
Date: Fri, 4 Dec 2020 16:38:50 +0100 [thread overview]
Message-ID: <20201204153850.GD2400258@lunn.ch> (raw)
In-Reply-To: <E1klCBD-0001si-Qj@rmk-PC.armlinux.org.uk>
On Fri, Dec 04, 2020 at 02:35:27PM +0000, Russell King wrote:
> Do not check the encoding when deriving 1000BASE-X from the bitrate
> when no other modes are discovered. Some GPON modules (VSOL V2801F
> and CarlitoxxPro CPGOS03-0490 v2.0) indicate NRZ encoding with a
> 1200Mbaud bitrate, but should be driven with 1000BASE-X on the host
> side.
Seems like somebody could make a nice side line writing SFP EEPROM
validation tools. There obviously are none in widespread use!
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2020-12-04 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 14:34 [PATCH net-next 0/2] Add support for VSOL V2801F/CarlitoxxPro CPGOS03 GPON module Russell King - ARM Linux admin
[not found] ` <E1klCB8-0001sW-Ma@rmk-PC.armlinux.org.uk>
2020-12-04 15:00 ` [PATCH net-next 1/2] net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround Russell King - ARM Linux admin
2020-12-04 15:31 ` Andrew Lunn
2020-12-09 11:20 ` Russell King - ARM Linux admin
[not found] ` <E1klCBD-0001si-Qj@rmk-PC.armlinux.org.uk>
2020-12-04 15:38 ` Andrew Lunn [this message]
2020-12-04 15:51 ` [PATCH net-next 2/2] net: sfp: relax bitrate-derived mode check Russell King - ARM Linux admin
2020-12-09 11:11 ` [PATCH net-next 0/2] Add support for VSOL V2801F/CarlitoxxPro CPGOS03 GPON module Russell King - ARM Linux admin
2020-12-09 11:17 ` Russell King - ARM Linux admin
-- strict thread matches above, loose matches on Subject: below --
2020-12-09 11:21 [PATCH RESEND " Russell King - ARM Linux admin
2020-12-09 11:22 ` [PATCH net-next 2/2] net: sfp: relax bitrate-derived mode check Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204153850.GD2400258@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pali@kernel$(echo .)org \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox