From: kernel test robot <lkp@intel•com>
To: Vladimir Oltean <olteanv@gmail•com>, Jakub Kicinski <kuba@kernel•org>
Cc: kbuild-all@lists•01.org, clang-built-linux@googlegroups•com,
Eric Dumazet <edumazet@google•com>,
Stephen Hemminger <stephen@networkplumber•org>,
netdev <netdev@vger•kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver•com>,
Jiri Benc <jbenc@redhat•com>, Or Gerlitz <ogerlitz@mellanox•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jamal Hadi Salim <jhs@mojatatu•com>, Andrew Lunn <andrew@lunn•ch>
Subject: Re: [PATCH] net: bonding: retrieve device statistics under RTNL, not RCU
Date: Thu, 10 Dec 2020 12:32:32 +0800 [thread overview]
Message-ID: <202012101201.pauYHu2o-lkp@intel.com> (raw)
In-Reply-To: <20201130184828.x56bwxxiwydsxt3k@skbuf>
[-- Attachment #1: Type: text/plain, Size: 5642 bytes --]
Hi Vladimir,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.10-rc7 next-20201209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/net-bonding-retrieve-device-statistics-under-RTNL-not-RCU/20201201-025343
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b65054597872ce3aefbc6a666385eabdf9e288da
config: mips-randconfig-r026-20201209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/ae1fadfd6122065f2a211de176290d184fda525a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vladimir-Oltean/net-bonding-retrieve-device-statistics-under-RTNL-not-RCU/20201201-025343
git checkout ae1fadfd6122065f2a211de176290d184fda525a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel•com>
All warnings (new ones prefixed by >>):
>> drivers/net/bonding/bond_main.c:3698:12: warning: unused function 'bond_get_lowest_level_rcu'
static int bond_get_lowest_level_rcu(struct net_device
^
fatal error: error in backend: Nested variants found in inline asm string: ' .set push
.set mips64r2
.if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/atomic.h", .line = 153, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif
1: ll $0, $1 # atomic_add
addu $0, $2
sc $0, $1
beqz $0, 1b
.set pop
'
clang-12: error: clang frontend command failed with exit code 70 (use -v to see invocation)
clang version 12.0.0 (git://gitmirror/llvm_project 1968804ac726e7674d5de22bc2204b45857da344)
Target: mipsel-unknown-linux-gnu
Thread model: posix
InstalledDir: /opt/cross/clang-1968804ac7/bin
clang-12: note: diagnostic msg:
Makefile arch drivers include kernel scripts source usr
vim +/bond_get_lowest_level_rcu +3698 drivers/net/bonding/bond_main.c
fe30937b65354c Eric Dumazet 2016-03-17 3696
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3697 #ifdef CONFIG_LOCKDEP
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 @3698 static int bond_get_lowest_level_rcu(struct net_device *dev)
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3699 {
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3700 struct net_device *ldev, *next, *now, *dev_stack[MAX_NEST_DEV + 1];
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3701 struct list_head *niter, *iter, *iter_stack[MAX_NEST_DEV + 1];
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3702 int cur = 0, max = 0;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3703
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3704 now = dev;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3705 iter = &dev->adj_list.lower;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3706
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3707 while (1) {
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3708 next = NULL;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3709 while (1) {
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3710 ldev = netdev_next_lower_dev_rcu(now, &iter);
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3711 if (!ldev)
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3712 break;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3713
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3714 next = ldev;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3715 niter = &ldev->adj_list.lower;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3716 dev_stack[cur] = now;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3717 iter_stack[cur++] = iter;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3718 if (max <= cur)
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3719 max = cur;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3720 break;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3721 }
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3722
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3723 if (!next) {
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3724 if (!cur)
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3725 return max;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3726 next = dev_stack[--cur];
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3727 niter = iter_stack[cur];
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3728 }
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3729
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3730 now = next;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3731 iter = niter;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3732 }
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3733
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3734 return max;
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3735 }
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3736 #endif
b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3737
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26899 bytes --]
prev parent reply other threads:[~2020-12-10 4:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201129182435.jgqfjbekqmmtaief@skbuf>
2020-11-29 20:58 ` Correct usage of dev_base_lock in 2020 Vladimir Oltean
2020-11-30 5:12 ` Stephen Hemminger
2020-11-30 10:41 ` Eric Dumazet
2020-11-30 18:14 ` Jakub Kicinski
2020-11-30 18:30 ` Eric Dumazet
2020-11-30 18:48 ` Vladimir Oltean
2020-11-30 19:00 ` Eric Dumazet
2020-11-30 19:03 ` Vladimir Oltean
2020-11-30 19:22 ` Eric Dumazet
2020-11-30 19:32 ` Vladimir Oltean
2020-11-30 21:41 ` Florian Fainelli
2020-11-30 19:46 ` Vladimir Oltean
2020-11-30 20:18 ` Eric Dumazet
2020-11-30 20:21 ` Stephen Hemminger
2020-11-30 20:26 ` Vladimir Oltean
2020-11-30 20:29 ` Eric Dumazet
2020-11-30 20:36 ` Vladimir Oltean
2020-11-30 20:43 ` Eric Dumazet
2020-11-30 20:50 ` Vladimir Oltean
2020-11-30 21:00 ` Eric Dumazet
2020-11-30 21:11 ` Vladimir Oltean
2020-11-30 21:46 ` Eric Dumazet
2020-11-30 21:53 ` Vladimir Oltean
2020-11-30 22:20 ` Eric Dumazet
2020-11-30 22:41 ` Vladimir Oltean
2020-12-01 14:42 ` Pablo Neira Ayuso
2020-12-01 18:58 ` Vladimir Oltean
2020-12-10 4:32 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012101201.pauYHu2o-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=clang-built-linux@googlegroups$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=jbenc@redhat$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=olteanv@gmail$(echo .)com \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox