Subject: Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

From: Marek Behún <[email-masked]>
Date: Wed, 30 Dec 2020 18:27:07 +0100

On Wed, 30 Dec 2020 18:06:52 +0100
Pali Rohár <[email-masked]> wrote:

> 	if (!sfp->type->module_supported(&id) &&
> 	    (memcmp(id.base.vendor_name, "UBNT            ", 16) ||
> 	     memcmp(id.base.vendor_pn, "UF-INSTANT      ", 16)))

I would rather add a quirk member (bitfield) to the sfp structure and do
something like this

if (!sfp->type->module_supported(&id) &&
    !(sfp->quirks & SFP_QUIRK_BAD_PHYS_ID))

or maybe put this check into the module_supported method.

Marek