Subject: Re: [PATCH iproute2 v2 1/1] build: Fix link errors on some systems

From: Stephen Hemminger <[email-masked]>
Date: Fri, 8 Jan 2021 08:18:06 -0800

On Fri, 8 Jan 2021 14:08:57 +0100
Petr Machata <[email-masked]> wrote:

> Stephen Hemminger <[email-masked]> writes:
> 
> > On Thu,  7 Jan 2021 09:13:34 +0200
> > Roi Dayan <[email-masked]> wrote:
> >  
> >> +#define _IS_JSON_CONTEXT(type) ((type & PRINT_JSON || type & PRINT_ANY) && is_json_context())
> >> +#define _IS_FP_CONTEXT(type) (!is_json_context() && (type & PRINT_FP || type & PRINT_ANY))  
> >
> > You could fold the comparisons? and why are the two options doing comparison in different order?
> >
> > #define _IS_JSON_CONTEXT(type) (is_json_context() && (type & (PRINT_JSON | PRINT_ANY))
> > #define _IS_FP_CONTEXT(type)   (!is_json_context() && (type & (PRINT_FP || PRINT_ANY))  
> 
> (s/||/|/)

Agree.
This was just an email edit, never tried