From: Edwin Peer <edwin.peer@broadcom•com>
To: netdev@vger•kernel.org
Cc: Edwin Peer <edwin.peer@broadcom•com>,
Jakub Kicinski <kuba@kernel•org>,
Andrew Gospodarek <andrew.gospodarek@broadcom•com>,
Michael Chan <michael.chan@broadcom•com>,
Stephen Hemminger <stephen@networkplumber•org>,
Michal Kubecek <mkubecek@suse•cz>,
David Ahern <dsahern@gmail•com>
Subject: [PATCH net-next 0/4] support for 256 VFs in RTM_GETLINK
Date: Fri, 22 Jan 2021 20:53:17 -0800 [thread overview]
Message-ID: <20210123045321.2797360-1-edwin.peer@broadcom.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]
RTM_GETLINK for greater than about 220 VFs truncates IFLA_VFINFO_LIST
due to the maximum reach of nlattr's nla_len being exceeded. There is
not a lot of enthusiasm for extensive fixes to the deprecated netlink
ABI for VF config, but there appears to be even less appetite for the
kinds of work arounds that would be necessitated in order to truly
keep it frozen [1].
This series first addresses nla_nest_end()'s propensity to generate
malformed netlink messages. The balance of the series comprises very
minor ABI updates intended to be low impact, in order to address the
remaining issues. First, the existing RTEXT_FILTER_SKIP_STATS is
called upon to alleviate the problem when user space does not want
statistics and then a minor tweak is introduced in two steps in order
to promote the stats one level up in the hierarchy with the minimum
of code churn.
Finally, the kernel series is followed by an iproute2 series to take
advantage of the changes.
[1] https://lore.kernel.org/netdev/20210115225950.18762-1-edwin.peer@broadcom.com/
Edwin Peer (4):
netlink: truncate overlength attribute list in nla_nest_end()
rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO
rtnetlink: refactor IFLA_VF_INFO stats into rtnl_fill_vfstats()
rtnetlink: promote IFLA_VF_STATS to same level as IFLA_VF_INFO
include/net/netlink.h | 11 ++-
include/uapi/linux/if_link.h | 1 +
include/uapi/linux/netlink.h | 1 +
include/uapi/linux/rtnetlink.h | 1 +
lib/nlattr.c | 27 +++++++
net/core/rtnetlink.c | 132 +++++++++++++++++++++------------
6 files changed, 122 insertions(+), 51 deletions(-)
--
2.30.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4160 bytes --]
next reply other threads:[~2021-01-23 4:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 4:53 Edwin Peer [this message]
2021-01-23 4:53 ` [PATCH net-next 1/4] netlink: truncate overlength attribute list in nla_nest_end() Edwin Peer
2021-01-23 19:14 ` David Ahern
2021-01-23 20:42 ` Edwin Peer
2021-01-23 21:03 ` Edwin Peer
2021-01-26 4:56 ` David Ahern
2021-01-26 17:51 ` Edwin Peer
2023-06-05 7:28 ` Gal Pressman
2023-06-05 18:58 ` Jakub Kicinski
2023-06-05 19:27 ` Edwin Peer
2023-06-06 8:01 ` Gal Pressman
2023-06-06 16:17 ` Jakub Kicinski
2023-06-07 13:31 ` Gal Pressman
2023-06-07 16:33 ` Jakub Kicinski
2023-06-07 16:52 ` Stephen Hemminger
2023-06-07 17:29 ` Jakub Kicinski
2021-01-26 4:50 ` David Ahern
2021-01-26 1:43 ` Jakub Kicinski
2021-01-23 4:53 ` [PATCH net-next 2/4] rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO Edwin Peer
2021-01-26 1:55 ` Jakub Kicinski
2021-01-26 22:48 ` Edwin Peer
2021-01-23 4:53 ` [PATCH net-next 3/4] rtnetlink: refactor IFLA_VF_INFO stats into rtnl_fill_vfstats() Edwin Peer
2021-01-23 4:53 ` [PATCH net-next 4/4] rtnetlink: promote IFLA_VF_STATS to same level as IFLA_VF_INFO Edwin Peer
2021-01-26 2:01 ` Jakub Kicinski
2021-01-26 14:50 ` Edwin Peer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123045321.2797360-1-edwin.peer@broadcom.com \
--to=edwin.peer@broadcom$(echo .)com \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox