From: Jesse Brandeburg <jesse.brandeburg@intel•com>
To: Alexander Lobakin <alobakin@pm•me>
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
David Rientjes <rientjes@google•com>,
Yisen Zhuang <yisen.zhuang@huawei•com>,
Salil Mehta <salil.mehta@huawei•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leon@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
Jesper Dangaard Brouer <brouer@redhat•com>,
Ilias Apalodimas <ilias.apalodimas@linaro•org>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
Willem de Bruijn <willemb@google•com>,
Randy Dunlap <rdunlap@infradead•org>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Dexuan Cui <decui@microsoft•com>,
Jakub Sitnicki <jakub@cloudflare•com>,
Marco Elver <elver@google•com>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
intel-wired-lan@lists•osuosl.org, linux-rdma@vger•kernel.org,
linux-mm@kvack•org
Subject: Re: [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage
Date: Wed, 27 Jan 2021 13:52:11 -0800 [thread overview]
Message-ID: <20210127135211.00005620@intel.com> (raw)
In-Reply-To: <20210127201031.98544-1-alobakin@pm.me>
Alexander Lobakin wrote:
> page_is_pfmemalloc() is used mostly by networking drivers to test
> if a page can be considered for reusing/recycling.
> It doesn't write anything to the struct page itself, so its sole
> argument can be constified, as well as the first argument of
> skb_propagate_pfmemalloc().
> In Page Pool core code, it can be simply inlined instead.
> Most of the callers from NIC drivers were just doppelgangers of
> the same condition tests. Derive them into a new common function
> do deduplicate the code.
This is a useful cleanup! Thanks.
For the series:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel•com>
prev parent reply other threads:[~2021-01-27 21:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 20:10 [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage Alexander Lobakin
2021-01-27 20:11 ` [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument Alexander Lobakin
2021-01-28 22:44 ` David Rientjes
2021-01-30 2:30 ` Jakub Kicinski
2021-01-27 20:11 ` [PATCH v2 net-next 2/4] skbuff: constify skb_propagate_pfmemalloc() "page" argument Alexander Lobakin
2021-01-28 22:45 ` David Rientjes
2021-01-27 20:11 ` [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved() Alexander Lobakin
2021-01-27 21:47 ` Jesse Brandeburg
2021-01-28 22:48 ` David Rientjes
2021-01-30 2:39 ` Jakub Kicinski
2021-01-30 15:42 ` Alexander Lobakin
2021-01-30 19:07 ` Jakub Kicinski
2021-01-30 19:45 ` Alexander Lobakin
2021-01-30 21:23 ` John Hubbard
2021-01-27 20:11 ` [PATCH v2 net-next 4/4] net: page_pool: simplify page recycling condition tests Alexander Lobakin
2021-01-28 22:49 ` David Rientjes
2021-01-27 21:52 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127135211.00005620@intel.com \
--to=jesse.brandeburg@intel$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alobakin@pm$(echo .)me \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=brouer@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=elver@google$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jakub@cloudflare$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=rientjes@google$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=willemb@google$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox