Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

From: Leon Romanovsky <[email-masked]>
Date: Thu, 28 Jan 2021 07:41:33 +0200

On Wed, Jan 27, 2021 at 07:16:41PM -0400, Jason Gunthorpe wrote:
> On Wed, Jan 27, 2021 at 10:17:56PM +0000, Saleem, Shiraz wrote:
>
> > Even with another core PCI driver, there still needs to be private
> > communication channel between the aux rdma driver and this PCI
> > driver to pass things like QoS updates.
>
> Data pushed from the core driver to its aux drivers should either be
> done through new callbacks in a struct device_driver or by having a
> notifier chain scheme from the core driver.

Right, and internal to driver/core device_lock will protect from
parallel probe/remove and PCI flows.

I would say that all this handmade register/unregister and peer_client
dance will be gone if driver would use properly auxbus.

Thanks

> Jason