From: Leon Romanovsky <leon@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Pablo Neira Ayuso <pablo@netfilter•org>
Cc: Leon Romanovsky <leonro@nvidia•com>,
coreteam@netfilter•org, Eric Dumazet <edumazet@google•com>,
Florian Westphal <fw@strlen•de>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
Julian Anastasov <ja@ssi•bg>,
linux-kernel@vger•kernel.org, lvs-devel@vger•kernel.org,
Matteo Croce <mcroce@redhat•com>,
netdev@vger•kernel.org, netfilter-devel@vger•kernel.org,
Simon Horman <horms@verge•net.au>
Subject: [PATCH net 1/4] ipv6: silence compilation warning for non-IPV6 builds
Date: Tue, 2 Feb 2021 15:55:41 +0200 [thread overview]
Message-ID: <20210202135544.3262383-2-leon@kernel.org> (raw)
In-Reply-To: <20210202135544.3262383-1-leon@kernel.org>
From: Leon Romanovsky <leonro@nvidia•com>
The W=1 compilation of allmodconfig generates the following warning:
net/ipv6/icmp.c:448:6: warning: no previous prototype for 'icmp6_send' [-Wmissing-prototypes]
448 | void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
| ^~~~~~~~~~
In such configuration, the icmp6_send() is not used outside of icmp.c, so close
its EXPORT_SYMBOL and add "static" word to limit the scope.
Fixes: cc7a21b6fbd9 ("ipv6: icmp6: avoid indirect call for icmpv6_send()")
Signed-off-by: Leon Romanovsky <leonro@nvidia•com>
---
net/ipv6/icmp.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index f3d05866692e..5d4232b492dc 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -445,6 +445,9 @@ static int icmp6_iif(const struct sk_buff *skb)
/*
* Send an ICMP message in response to a packet in error
*/
+#if !IS_BUILTIN(CONFIG_IPV6)
+static
+#endif
void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
const struct in6_addr *force_saddr)
{
@@ -634,7 +637,10 @@ void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
out_bh_enable:
local_bh_enable();
}
+
+#if IS_BUILTIN(CONFIG_IPV6)
EXPORT_SYMBOL(icmp6_send);
+#endif
/* Slightly more convenient version of icmp6_send.
*/
--
2.29.2
next prev parent reply other threads:[~2021-02-02 14:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 13:55 [PATCH net 0/4] Fix W=1 compilation warnings in net/* folder Leon Romanovsky
2021-02-02 13:55 ` Leon Romanovsky [this message]
2021-02-02 16:29 ` [PATCH net 1/4] ipv6: silence compilation warning for non-IPV6 builds Jakub Kicinski
2021-02-02 18:55 ` Leon Romanovsky
2021-02-02 21:55 ` Jakub Kicinski
2021-02-02 13:55 ` [PATCH net 2/4] ipv6: move udp declarations to net/udp.h Leon Romanovsky
2021-02-02 13:55 ` [PATCH net 3/4] net/core: move ipv6 gro function declarations to net/ipv6 Leon Romanovsky
2021-02-02 14:57 ` Eric Dumazet
2021-02-02 15:59 ` Leon Romanovsky
2021-02-02 13:55 ` [PATCH net 4/4] netfilter: move handlers to net/ip_vs.h Leon Romanovsky
2021-02-02 14:34 ` [PATCH net 0/4] Fix W=1 compilation warnings in net/* folder Eric Dumazet
2021-02-02 14:57 ` Leon Romanovsky
2021-02-02 14:59 ` Eric Dumazet
2021-02-02 15:54 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202135544.3262383-2-leon@kernel.org \
--to=leon@kernel$(echo .)org \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=horms@verge$(echo .)net.au \
--cc=ja@ssi$(echo .)bg \
--cc=kadlec@netfilter$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leonro@nvidia$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=mcroce@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox