From: Ido Schimmel <idosch@idosch•org>
To: Leon Romanovsky <leon@kernel•org>
Cc: Chris Mi <cmi@nvidia•com>, Jakub Kicinski <kuba@kernel•org>,
Cong Wang <xiyou.wangcong@gmail•com>,
Linux Kernel Network Developers <netdev@vger•kernel.org>,
jiri@nvidia•com, Saeed Mahameed <saeedm@nvidia•com>,
kernel test robot <lkp@intel•com>
Subject: Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency
Date: Mon, 8 Feb 2021 10:57:46 +0200 [thread overview]
Message-ID: <20210208085746.GA179437@shredder.lan> (raw)
In-Reply-To: <20210208070350.GB4656@unreal>
On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote:
> On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote:
> > On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote:
> > > Hi Ido,
> > >
> > > On 1/30/2021 10:42 PM, Ido Schimmel wrote:
> > > > On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote:
> > > > > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
> > > > > > Instead of discussing it several days, maybe it's better to review
> > > > > > current patch, so that we can move forward :)
> > > > > It took you 4 revisions to post a patch which builds cleanly and now
> > > > > you want to hasten the review? My favorite kind of submission.
> > > > >
> > > > > The mlxsw core + spectrum drivers are 65 times the size of psample
> > > > > on my system. Why is the dependency a problem?
> > > > mlxsw has been using psample for ~4 years and I don't remember seeing a
> > > > single complaint about the dependency. I don't understand why this patch
> > > > is needed.
> > > Please see Saeed's comment in previous email:
> > >
> > > "
> > >
> > > The issue is with distros who ship modules independently.. having a
> > > hard dependency will make it impossible for basic mlx5_core.ko users to
> > > load the driver when psample is not installed/loaded.
> > >
> > > I prefer to have 0 dependency on external modules in a HW driver.
> > > "
> >
> > I saw it, but it basically comes down to personal preferences.
>
> It is more than personal preferences. In opposite to the mlxsw which is
> used for netdev only, the mlx5_core is used by other subsystems, e.g. RDMA,
> so Saeed's request to avoid extra dependencies makes sense.
>
> We don't need psample dependency to run RDMA traffic.
Right, you don't need it. The dependency is "PSAMPLE || PSAMPLE=n". You
can compile out psample and RDMA will work.
>
> >
> > >
> > > We are working on a tc sample offload feature for mlx5_core. The distros
> > > are likely to request us to do this. So we address it before submitting
> > > the driver changes.
> >
> > Which distros? Can they comment here? mlxsw is in RHEL and I don't
> > remember queries from them about the psample module.
>
> There is a huge difference between being in RHEL and actively work with
> partners as mlx5 does.
>
> The open mailing list is not the right place to discuss our partnership
> relations.
I did not ask about "partnership relations". I asked for someone more
familiar with the problem that can explain the distro issue. But if such
a basic question can't be asked, then the distro argument should not
have been made in the first place.
next prev parent reply other threads:[~2021-02-08 9:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 1:45 [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency Chris Mi
2021-01-29 5:14 ` Cong Wang
2021-01-29 6:08 ` Chris Mi
2021-01-29 20:30 ` Jakub Kicinski
2021-01-29 20:44 ` Saeed Mahameed
2021-01-29 21:47 ` Jakub Kicinski
2021-01-30 14:42 ` Ido Schimmel
2021-02-01 1:37 ` Chris Mi
2021-02-01 18:08 ` Ido Schimmel
2021-02-08 7:03 ` Leon Romanovsky
2021-02-08 8:57 ` Ido Schimmel [this message]
2021-02-08 9:07 ` Leon Romanovsky
2021-02-08 17:07 ` Ido Schimmel
2021-02-09 6:47 ` Leon Romanovsky
2021-02-09 9:25 ` Or Gerlitz
2021-02-09 10:01 ` Leon Romanovsky
2021-02-09 10:49 ` Or Gerlitz
2021-02-11 5:09 ` Saeed Mahameed
2021-02-11 21:59 ` Ido Schimmel
2021-02-12 0:41 ` Saeed Mahameed
2021-01-29 21:50 ` Jakub Kicinski
2021-01-30 2:35 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208085746.GA179437@shredder.lan \
--to=idosch@idosch$(echo .)org \
--cc=cmi@nvidia$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=lkp@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@nvidia$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox