Subject: Re: [PATCH net-next 8/8] mld: change context of mld module

From: kernel test robot <[email-masked]>
Date: Tue, 9 Feb 2021 10:33:44 +0800

Hi Taehee,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9ac7d23c98251efc265073a0d63930c91739cc02
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339
        git checkout 9ac7d23c98251efc265073a0d63930c91739cc02
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All warnings (new ones prefixed by >>):

>> net/ipv6/mcast.c:333:6: warning: no previous prototype for 'mld_check_leave_group' [-Wmissing-prototypes]
     333 | bool mld_check_leave_group(struct ipv6_mc_socklist *mc_lst, int omode)
         |      ^~~~~~~~~~~~~~~~~~~~~
   net/ipv6/mcast.c: In function 'ip6_mc_del_src':
   net/ipv6/mcast.c:2153:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
    2153 |  int i, err, rv;
         |      ^

vim +/mld_check_leave_group +333 net/ipv6/mcast.c

   331	
   332	/* special case - (INCLUDE, empty) == LEAVE_GROUP */
 > 333	bool mld_check_leave_group(struct ipv6_mc_socklist *mc_lst, int omode)
   334	{
   335		if (atomic_read(&mc_lst->sl_count) == 1 && omode == MCAST_INCLUDE)
   336			return true;
   337		else
   338			return false;
   339	}
   340	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]