Subject: Re: [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

From: Maxime Chevallier <[email-masked]>
Date: Mon, 15 Feb 2021 16:06:54 +0100

Hi Pali,

On Mon, 15 Feb 2021 00:50:58 +0100
Pali Rohár <[email-masked]> wrote:

>> According to Errata #23 "The per-CPU GbE interrupt is limited to Core
>> 0", we can't use the per-cpu interrupt mechanism on the Armada 3700
>> familly.
>> 
>> This is correctly checked for RSS configuration, but the initial queue
>> mapping is still done by having the queues spread across all the CPUs in
>> the system, both in the init path and in the cpu_hotplug path.  
>
>Hello Maxime!
>
>This patch looks like a bug fix for Armada 3700 SoC. What about marking
>this commit with Fixes line? E.g.:
>
>    Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 SoC")

Yes you're correct, I'll add that to the V2 !

Thanks for the review,

Maxime

-- 
Maxime Chevallier, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com