Subject: Re: [PATCH] xfrm: Fix incorrect types in assignment

From: Florian Westphal <[email-masked]>
Date: Fri, 19 Feb 2021 15:02:00 +0100

Yang Li <[email-masked]> wrote:
> Fix the following sparse warnings:
> net/xfrm/xfrm_policy.c:1303:22: warning: incorrect type in assignment
> (different address spaces)
> Reported-by: Abaci Robot <[email-masked]>
> Signed-off-by: Yang Li <[email-masked]>
> ---
>  net/xfrm/xfrm_policy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index b74f28c..5c67407 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -1225,7 +1225,7 @@ static void xfrm_hash_rebuild(struct work_struct *work)
>  	struct xfrm_policy *pol;
>  	struct xfrm_policy *policy;
>  	struct hlist_head *chain;
> -	struct hlist_head *odst;
> +	struct hlist_head __rcu *odst;

This doesn't look right.  Try something like

- odst = net->xfrm.policy_bydst[dir].table;
+ odst = rcu_dereference_protected(net->xfrm.policy_bydst[dir].table,
			           lockdep_is_held(&net->xfrm.xfrm_policy_lock));