Subject: Re: [PATCH 042/141] net: 3c509: Fix fall-through warnings for Clang

From: "Gustavo A. R. Silva" <[email-masked]>
Date: Thu, 4 Mar 2021 16:50:39 -0600

Hi all,

It's been more than 3 months; who can take this, please? :)

Thanks
--
Gustavo

On Fri, Nov 20, 2020 at 12:30:56PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email-masked]>
> ---
>  drivers/net/ethernet/3com/3c509.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c
> index 667f38c9e4c6..676cdc6900b5 100644
> --- a/drivers/net/ethernet/3com/3c509.c
> +++ b/drivers/net/ethernet/3com/3c509.c
> @@ -1052,6 +1052,7 @@ el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
>  		break;
>  	case 3:
>  		cmd->base.port = PORT_BNC;
> +		break;
>  	default:
>  		break;
>  	}
> -- 
> 2.27.0
>