Subject: Re: [PATCH 111/141] net: plip: Fix fall-through warnings for Clang

From: "Gustavo A. R. Silva" <[email-masked]>
Date: Thu, 4 Mar 2021 17:00:23 -0600

Hi all,

It's been more than 3 months; who can take this, please? :)

Thanks
--
Gustavo

On Fri, Nov 20, 2020 at 12:38:25PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email-masked]>
> ---
>  drivers/net/plip/plip.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
> index 4406b353123e..e26cf91bdec2 100644
> --- a/drivers/net/plip/plip.c
> +++ b/drivers/net/plip/plip.c
> @@ -516,6 +516,7 @@ plip_receive(unsigned short nibble_timeout, struct net_device *dev,
>  		*data_p |= (c0 << 1) & 0xf0;
>  		write_data (dev, 0x00); /* send ACK */
>  		*ns_p = PLIP_NB_BEGIN;
> +		break;
>  	case PLIP_NB_2:
>  		break;
>  	}
> @@ -808,6 +809,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
>  				return HS_TIMEOUT;
>  			}
>  		}
> +		break;
>  
>  	case PLIP_PK_LENGTH_LSB:
>  		if (plip_send(nibble_timeout, dev,
> -- 
> 2.27.0
>