Subject: Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

From: Simon Horman <[email-masked]>
Date: Fri, 5 Mar 2021 13:19:50 +0100

On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email-masked]>

Thanks Gustavo,

this looks good to me.

Acked-by: Simon Horman <[email-masked]>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> index b3cabc274121..3b8e675087de 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
>  	case NFP_PORT_PF_PORT:
>  	case NFP_PORT_VF_PORT:
>  		nfp_repr_vnic_get_stats64(repr->port, stats);
> +		break;
>  	default:
>  		break;
>  	}
> -- 
> 2.27.0
>