public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@netronome•com>
To: Alexander Duyck <alexander.duyck@gmail•com>
Cc: kuba@kernel•org, netdev@vger•kernel.org,
	oss-drivers@netronome•com, yisen.zhuang@huawei•com,
	salil.mehta@huawei•com, intel-wired-lan@lists•osuosl.org,
	jesse.brandeburg@intel•com, anthony.l.nguyen@intel•com,
	drivers@pensando•io, snelson@pensando•io, netanel@amazon•com,
	akiyano@amazon•com, gtzalik@amazon•com, saeedb@amazon•com,
	GR-Linux-NIC-Dev@marvell•com, skalluru@marvell•com,
	rmody@marvell•com, kys@microsoft•com, haiyangz@microsoft•com,
	sthemmin@microsoft•com, wei.liu@kernel•org, mst@redhat•com,
	jasowang@redhat•com, pv-drivers@vmware•com, doshir@vmware•com,
	alexanderduyck@fb•com
Subject: Re: [RFC PATCH 03/10] nfp: Replace nfp_pr_et with ethtool_gsprintf
Date: Thu, 11 Mar 2021 12:51:15 +0100	[thread overview]
Message-ID: <20210311115115.GA12530@netronome.com> (raw)
In-Reply-To: <161542653266.13546.11914667071718045956.stgit@localhost.localdomain>

On Wed, Mar 10, 2021 at 05:35:32PM -0800, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@fb•com>
> 
> The nfp_pr_et function is nearly identical to ethtool_gsprintf except for
> the fact that it passes the pointer by value and as a return whereas
> ethtool_gsprintf passes it as a pointer.
> 
> Since they are so close just update nfp to make use of ethtool_gsprintf
> 
> Signed-off-by: Alexander Duyck <alexanderduyck@fb•com>

Reviewed-by: Simon Horman <simon.horman@netronome•com>

  reply	other threads:[~2021-03-11 11:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  1:35 [RFC PATCH 00/10] ethtool: Factor out common code related to writing ethtool strings Alexander Duyck
2021-03-11  1:35 ` [RFC PATCH 01/10] ethtool: Add common function for filling out strings Alexander Duyck
2021-03-11  2:08   ` Jakub Kicinski
2021-03-11 20:37     ` Jesse Brandeburg
2021-03-11  1:35 ` [RFC PATCH 02/10] intel: Update drivers to use ethtool_gsprintf Alexander Duyck
2021-03-11 20:32   ` Jesse Brandeburg
2021-03-11  1:35 ` [RFC PATCH 03/10] nfp: Replace nfp_pr_et with ethtool_gsprintf Alexander Duyck
2021-03-11 11:51   ` Simon Horman [this message]
2021-03-11  1:35 ` [RFC PATCH 04/10] hisilicon: Update drivers to use ethtool_gsprintf Alexander Duyck
2021-03-11  1:35 ` [RFC PATCH 05/10] ena: Update driver " Alexander Duyck
2021-03-11 13:42   ` Kiyanovski, Arthur
2021-03-11  1:35 ` [RFC PATCH 06/10] netvsc: " Alexander Duyck
2021-03-11  1:35 ` [RFC PATCH 07/10] virtio_net: " Alexander Duyck
2021-03-11  1:36 ` [RFC PATCH 08/10] vmxnet3: " Alexander Duyck
2021-03-11  1:36 ` [RFC PATCH 09/10] bna: " Alexander Duyck
2021-03-11  1:36 ` [RFC PATCH 10/10] ionic: " Alexander Duyck
2021-03-11 17:19   ` Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311115115.GA12530@netronome.com \
    --to=simon.horman@netronome$(echo .)com \
    --cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
    --cc=akiyano@amazon$(echo .)com \
    --cc=alexander.duyck@gmail$(echo .)com \
    --cc=alexanderduyck@fb$(echo .)com \
    --cc=anthony.l.nguyen@intel$(echo .)com \
    --cc=doshir@vmware$(echo .)com \
    --cc=drivers@pensando$(echo .)io \
    --cc=gtzalik@amazon$(echo .)com \
    --cc=haiyangz@microsoft$(echo .)com \
    --cc=intel-wired-lan@lists$(echo .)osuosl.org \
    --cc=jasowang@redhat$(echo .)com \
    --cc=jesse.brandeburg@intel$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=kys@microsoft$(echo .)com \
    --cc=mst@redhat$(echo .)com \
    --cc=netanel@amazon$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=oss-drivers@netronome$(echo .)com \
    --cc=pv-drivers@vmware$(echo .)com \
    --cc=rmody@marvell$(echo .)com \
    --cc=saeedb@amazon$(echo .)com \
    --cc=salil.mehta@huawei$(echo .)com \
    --cc=skalluru@marvell$(echo .)com \
    --cc=snelson@pensando$(echo .)io \
    --cc=sthemmin@microsoft$(echo .)com \
    --cc=wei.liu@kernel$(echo .)org \
    --cc=yisen.zhuang@huawei$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox