Subject: Re: [PATCH v3 net-next 0/2] pktgen: scripts improvements

From: Jesper Dangaard Brouer <[email-masked]>
Date: Mon, 15 Mar 2021 09:45:30 +0100

On Thu, 11 Mar 2021 11:32:51 +0100
Igor Russkikh <[email-masked]> wrote:

> Hello netdev community,
> 
> Please consider small improvements to pktgen scripts we use in our environment.
> 
> Adding delay parameter through command line,
> Adding new -a (append) parameter to make flex runs
> 
> v3: change us to ns in docs
> v2: Review comments from Jesper
> 
> CC: Jesper Dangaard Brouer <[email-masked]>

Did a quick review and everything looks okay.
The patches are already applied, but you will still get my ACK,
even-though it will not make it to the commit log.

Acked-by: Jesper Dangaard Brouer <[email-masked]>

> Igor Russkikh (2):
>   samples: pktgen: allow to specify delay parameter via new opt
>   samples: pktgen: new append mode
> 
>  samples/pktgen/README.rst                     | 18 +++++++++++
>  samples/pktgen/functions.sh                   |  7 ++++-
>  samples/pktgen/parameters.sh                  | 15 ++++++++-
>  .../pktgen_bench_xmit_mode_netif_receive.sh   |  3 --
>  .../pktgen_bench_xmit_mode_queue_xmit.sh      |  3 --
>  samples/pktgen/pktgen_sample01_simple.sh      | 25 ++++++++-------
>  samples/pktgen/pktgen_sample02_multiqueue.sh  | 29 +++++++++--------
>  .../pktgen_sample03_burst_single_flow.sh      | 15 ++++-----
>  samples/pktgen/pktgen_sample04_many_flows.sh  | 17 +++++-----
>  .../pktgen/pktgen_sample05_flow_per_thread.sh | 17 +++++-----
>  ...sample06_numa_awared_queue_irq_affinity.sh | 31 ++++++++++---------
>  11 files changed, 110 insertions(+), 70 deletions(-)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer