Subject: Re: [PATCH 126/190] Revert "net: openvswitch: fix a NULL pointer dereference"

From: Matteo Croce <[email-masked]>
Date: Thu, 22 Apr 2021 01:59:57 +0200

On Wed, 21 Apr 2021 15:00:01 +0200
Greg Kroah-Hartman <[email-masked]> wrote:

> This reverts commit 6f19893b644a9454d85e593b5e90914e7a72b7dd.
> 
> Commits from @umn.edu addresses have been found to be submitted in
> "bad faith" to try to test the kernel community's ability to review
> "known malicious" changes.  The result of these submissions can be
> found in a paper published at the 42nd IEEE Symposium on Security and
> Privacy entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu
> (University of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove
> this change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Kangjie Lu <[email-masked]>
> Cc: David S. Miller <[email-masked]>
> Signed-off-by: Greg Kroah-Hartman <[email-masked]>
> ---
>  net/openvswitch/datapath.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index 9d6ef6cb9b26..99e63f4bbcaf 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c
> @@ -443,10 +443,6 @@ static int queue_userspace_packet(struct
> datapath *dp, struct sk_buff *skb, 
>  	upcall = genlmsg_put(user_skb, 0, 0, &dp_packet_genl_family,
>  			     0, upcall_info->cmd);
> -	if (!upcall) {
> -		err = -EINVAL;
> -		goto out;
> -	}
>  	upcall->dp_ifindex = dp_ifindex;
>  
>  	err = ovs_nla_put_key(key, key, OVS_PACKET_ATTR_KEY, false,
> user_skb);

This patch seems good to me, but given the situation I'd like another
pair of eyes on it, at least.

Regards,
-- 
per aspera ad upstream