From: "Marek Behún" <kabel@kernel•org>
To: linux-leds@vger•kernel.org
Cc: netdev@vger•kernel.org, "Pavel Machek" <pavel@ucw•cz>,
"Dan Murphy" <dmurphy@ti•com>,
"Russell King" <linux@armlinux•org.uk>,
"Andrew Lunn" <andrew@lunn•ch>,
"Matthias Schiffer" <matthias.schiffer@ew•tq-group.com>,
"Jacek Anaszewski" <jacek.anaszewski@gmail•com>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel•org>,
"Marek Behún" <kabel@kernel•org>
Subject: [PATCH leds v2 01/10] leds: trigger: netdev: don't explicitly zero kzalloced data
Date: Tue, 1 Jun 2021 02:51:46 +0200 [thread overview]
Message-ID: <20210601005155.27997-2-kabel@kernel.org> (raw)
In-Reply-To: <20210601005155.27997-1-kabel@kernel.org>
The trigger_data struct is allocated with kzalloc, so we do not need to
explicitly set members to zero.
Signed-off-by: Marek Behún <kabel@kernel•org>
Acked-by: Pavel Machek <pavel@ucw•cz>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
---
drivers/leds/trigger/ledtrig-netdev.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
index d5e774d83021..4f6b73e3b491 100644
--- a/drivers/leds/trigger/ledtrig-netdev.c
+++ b/drivers/leds/trigger/ledtrig-netdev.c
@@ -406,12 +406,8 @@ static int netdev_trig_activate(struct led_classdev *led_cdev)
INIT_DELAYED_WORK(&trigger_data->work, netdev_trig_work);
trigger_data->led_cdev = led_cdev;
- trigger_data->net_dev = NULL;
- trigger_data->device_name[0] = 0;
- trigger_data->mode = 0;
atomic_set(&trigger_data->interval, msecs_to_jiffies(50));
- trigger_data->last_activity = 0;
led_set_trigger_data(led_cdev, trigger_data);
--
2.26.3
next prev parent reply other threads:[~2021-06-01 0:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 0:51 [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia Marek Behún
2021-06-01 0:51 ` Marek Behún [this message]
2021-06-01 0:51 ` [PATCH leds v2 02/10] leds: trigger: add API for HW offloading of triggers Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 03/10] leds: trigger: netdev: move trigger data structure to global include dir Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 04/10] leds: trigger: netdev: support HW offloading Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 05/10] leds: trigger: netdev: change spinlock to mutex Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 06/10] leds: core: inform trigger that it's deactivation is due to LED removal Marek Behún
2021-06-01 21:12 ` Andrew Lunn
2021-06-02 12:44 ` Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 07/10] leds: turris-omnia: refactor sw mode setting code into separate function Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 08/10] leds: turris-omnia: refactor brightness setting function Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 09/10] leds: turris-omnia: initialize each multicolor LED to white color Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 10/10] leds: turris-omnia: support offloading netdev trigger for WAN LED Marek Behún
2021-06-01 1:44 ` Marek Behún
2021-06-01 21:19 ` Andrew Lunn
2025-10-16 11:43 ` [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia Lad, Prabhakar
2025-10-16 13:14 ` Andrew Lunn
2025-10-16 18:53 ` Lad, Prabhakar
2025-10-16 19:11 ` Andrew Lunn
2025-10-16 19:25 ` Lad, Prabhakar
2025-10-16 19:44 ` Andrew Lunn
2025-10-17 15:23 ` Lad, Prabhakar
2025-10-21 10:50 ` Lee Jones
2025-11-05 13:32 ` Lad, Prabhakar
2025-11-05 15:48 ` Andrew Lunn
2025-11-05 17:52 ` Lad, Prabhakar
2025-11-05 18:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601005155.27997-2-kabel@kernel.org \
--to=kabel@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=dmurphy@ti$(echo .)com \
--cc=jacek.anaszewski@gmail$(echo .)com \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=matthias.schiffer@ew$(echo .)tq-group.com \
--cc=mchehab+huawei@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel@ucw$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox