Subject: Re: [PATCH net-next 02/13] net: stmmac: reverse Christmas tree notation in stmmac_xpcs_setup

From: Wong Vee Khee <[email-masked]>
Date: Thu, 10 Jun 2021 07:28:43 +0800

On Wed, Jun 09, 2021 at 09:41:44PM +0300, Vladimir Oltean wrote:
> From: Vladimir Oltean <[email-masked]>
> 
> Reorder the variable declarations in descending line length order,
> according to the networking coding style.
> 
> Signed-off-by: Vladimir Oltean <[email-masked]>

Reviewed-by: Wong Vee Khee <[email-masked]>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index 3b3033b20b1d..a5d150c5f3d8 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -399,11 +399,11 @@ int stmmac_mdio_reset(struct mii_bus *bus)
>  
>  int stmmac_xpcs_setup(struct mii_bus *bus)
>  {
> -	int mode, addr;
>  	struct net_device *ndev = bus->priv;
> -	struct dw_xpcs *xpcs;
> -	struct stmmac_priv *priv;
>  	struct mdio_device *mdiodev;
> +	struct stmmac_priv *priv;
> +	struct dw_xpcs *xpcs;
> +	int mode, addr;
>  
>  	priv = netdev_priv(ndev);
>  	mode = priv->plat->phy_interface;
> -- 
> 2.25.1
>