Subject: Re: [PATCH net-next 3/3] net: phy: nxp-c45-tja11xx: enable MDIO write access to the master/slave registers

From: "Russell King (Oracle)" <[email-masked]>
Date: Mon, 14 Jun 2021 13:29:19 +0100

On Mon, Jun 14, 2021 at 03:18:49PM +0300, Vladimir Oltean wrote:
> diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
> index 118b393b1cbb..b4dc112d4881 100644
> --- a/drivers/net/phy/nxp-c45-tja11xx.c
> +++ b/drivers/net/phy/nxp-c45-tja11xx.c
> @@ -1035,6 +1035,9 @@ static int nxp_c45_config_init(struct phy_device *phydev)
>  		return ret;
>  	}
>  
> +	phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F8, 1);
> +	phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F9, 2);

I think this deserves a comment - especially since the code uses numeric
values here.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!