From: Richard Cochran <richardcochran@gmail•com>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
davem@davemloft•net, netdev@vger•kernel.org, sassmann@redhat•com,
Tony Brelinski <tonyx.brelinski@intel•com>
Subject: Re: [PATCH net-next 5/8] ice: register 1588 PTP clock device object for E810 devices
Date: Mon, 14 Jun 2021 11:12:20 -0700 [thread overview]
Message-ID: <20210614181218.GA7788@localhost> (raw)
In-Reply-To: <ca27bafc-fdc2-c5f1-fc37-1cdf48d393b2@intel.com>
On Mon, Jun 14, 2021 at 09:43:17AM -0700, Jacob Keller wrote:
> > Since dialed_freq is updated regardless of return value of .adjfine
> > the driver has no clear way to reject bad scaled_ppm>
>
> I'm not sure. +Richard?
The driver advertises "max_adj". The PHC layer checks user space inputs:
ptp_clock.c line 140:
} else if (tx->modes & ADJ_FREQUENCY) {
s32 ppb = scaled_ppm_to_ppb(tx->freq);
if (ppb > ops->max_adj || ppb < -ops->max_adj)
return -ERANGE;
So, if the max_adj is correct for the driver/HW, then all is well.
Thanks,
Richard
next prev parent reply other threads:[~2021-06-14 18:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 16:19 [PATCH net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2021-06-11 Tony Nguyen
2021-06-11 16:19 ` [PATCH net-next 1/8] ice: add support for sideband messages Tony Nguyen
2021-06-11 16:19 ` [PATCH net-next 2/8] ice: process 1588 PTP capabilities during initialization Tony Nguyen
2021-06-11 16:19 ` [PATCH net-next 3/8] ice: add support for set/get of driver-stored firmware parameters Tony Nguyen
2021-06-11 16:19 ` [PATCH net-next 4/8] ice: add low level PTP clock access functions Tony Nguyen
2021-06-11 16:19 ` [PATCH net-next 5/8] ice: register 1588 PTP clock device object for E810 devices Tony Nguyen
2021-06-11 21:18 ` Jakub Kicinski
2021-06-14 16:43 ` Jacob Keller
2021-06-14 18:08 ` Jakub Kicinski
2021-06-14 19:50 ` Keller, Jacob E
2021-06-14 20:48 ` Jakub Kicinski
2021-06-14 20:51 ` Jacob Keller
2021-06-14 22:25 ` Jakub Kicinski
2021-06-14 18:12 ` Richard Cochran [this message]
2021-06-14 18:50 ` Jakub Kicinski
2021-06-14 19:48 ` Keller, Jacob E
2021-06-15 5:08 ` Richard Cochran
2021-06-11 16:19 ` [PATCH net-next 6/8] ice: report the PTP clock index in ethtool .get_ts_info Tony Nguyen
2021-06-11 16:19 ` [PATCH net-next 7/8] ice: enable receive hardware timestamping Tony Nguyen
2021-06-11 16:20 ` [PATCH net-next 8/8] ice: enable transmit timestamps for E810 devices Tony Nguyen
2021-06-11 21:00 ` [PATCH net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2021-06-11 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614181218.GA7788@localhost \
--to=richardcochran@gmail$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sassmann@redhat$(echo .)com \
--cc=tonyx.brelinski@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox