From: Saeed Mahameed <saeed@kernel•org>
To: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>
Cc: netdev@vger•kernel.org, Eli Cohen <elic@nvidia•com>,
Parav Pandit <parav@nvidia•com>,
Saeed Mahameed <saeedm@nvidia•com>
Subject: [net-next 4/6] net/mlx5: SF, Improve performance in SF allocation
Date: Sat, 26 Jun 2021 00:44:15 -0700 [thread overview]
Message-ID: <20210626074417.714833-5-saeed@kernel.org> (raw)
In-Reply-To: <20210626074417.714833-1-saeed@kernel.org>
From: Eli Cohen <elic@nvidia•com>
Avoid second traversal on the SF table by recording the first free entry
and using it in case the looked up entry was not found in the table.
Signed-off-by: Eli Cohen <elic@nvidia•com>
Signed-off-by: Parav Pandit <parav@nvidia•com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia•com>
---
.../ethernet/mellanox/mlx5/core/sf/hw_table.c | 23 +++++++++++--------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c b/drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c
index 500c71fb6f6d..d9c69123c1ab 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c
@@ -73,26 +73,29 @@ static int mlx5_sf_hw_table_id_alloc(struct mlx5_sf_hw_table *table, u32 control
u32 usr_sfnum)
{
struct mlx5_sf_hwc_table *hwc;
+ int free_idx = -1;
int i;
hwc = mlx5_sf_controller_to_hwc(table->dev, controller);
if (!hwc->sfs)
return -ENOSPC;
- /* Check if sf with same sfnum already exists or not. */
for (i = 0; i < hwc->max_fn; i++) {
+ if (!hwc->sfs[i].allocated && free_idx == -1) {
+ free_idx = i;
+ continue;
+ }
+
if (hwc->sfs[i].allocated && hwc->sfs[i].usr_sfnum == usr_sfnum)
return -EEXIST;
}
- /* Find the free entry and allocate the entry from the array */
- for (i = 0; i < hwc->max_fn; i++) {
- if (!hwc->sfs[i].allocated) {
- hwc->sfs[i].usr_sfnum = usr_sfnum;
- hwc->sfs[i].allocated = true;
- return i;
- }
- }
- return -ENOSPC;
+
+ if (free_idx == -1)
+ return -ENOSPC;
+
+ hwc->sfs[free_idx].usr_sfnum = usr_sfnum;
+ hwc->sfs[free_idx].allocated = true;
+ return free_idx;
}
static void mlx5_sf_hw_table_id_free(struct mlx5_sf_hw_table *table, u32 controller, int id)
--
2.31.1
next prev parent reply other threads:[~2021-06-26 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 7:44 [pull request][net-next 0/6] mlx5 updates 2021-06-26 Saeed Mahameed
2021-06-26 7:44 ` [net-next 1/6] net/mlx5: Compare sampler flow destination ID in fs_core Saeed Mahameed
2021-06-28 21:20 ` patchwork-bot+netdevbpf
2021-06-26 7:44 ` [net-next 2/6] net/mlx5: DR, Add support for flow sampler offload Saeed Mahameed
2021-06-26 7:44 ` [net-next 3/6] net/mlx5: Increase hairpin buffer size Saeed Mahameed
2021-06-26 7:44 ` Saeed Mahameed [this message]
2021-06-26 7:44 ` [net-next 5/6] net/mlx5e: kTLS, Add stats for number of deleted kTLS TX offloaded connections Saeed Mahameed
2021-06-26 7:44 ` [net-next 6/6] net/mlx5e: Add IPsec support to uplink representor Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210626074417.714833-5-saeed@kernel.org \
--to=saeed@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=elic@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=parav@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox