Subject: Re: [PATCH net-next] openvswitch: Introduce per-cpu upcall dispatch

From: kernel test robot <[email-masked]>
Date: Thu, 1 Jul 2021 00:29:03 +0800

Hi Mark,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Mark-Gray/openvswitch-Introduce-per-cpu-upcall-dispatch/20210630-175435
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b6df00789e2831fff7a2c65aa7164b2a4dcbe599
config: sh-randconfig-s032-20210630 (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/24234cf5ef3fdbb1cad04189ba6459292f84180e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mark-Gray/openvswitch-Introduce-per-cpu-upcall-dispatch/20210630-175435
        git checkout 24234cf5ef3fdbb1cad04189ba6459292f84180e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

sparse warnings: (new ones prefixed by >>)
>> net/openvswitch/datapath.c:169:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const * @@     got struct dp_nlsk_pids [noderef] __rcu *upcall_portids @@
   net/openvswitch/datapath.c:169:17: sparse:     expected void const *
   net/openvswitch/datapath.c:169:17: sparse:     got struct dp_nlsk_pids [noderef] __rcu *upcall_portids

vim +169 net/openvswitch/datapath.c

   160	
   161	static void destroy_dp_rcu(struct rcu_head *rcu)
   162	{
   163		struct datapath *dp = container_of(rcu, struct datapath, rcu);
   164	
   165		ovs_flow_tbl_destroy(&dp->table);
   166		free_percpu(dp->stats_percpu);
   167		kfree(dp->ports);
   168		ovs_meters_exit(dp);
 > 169		kfree(dp->upcall_portids);
   170		kfree(dp);
   171	}
   172	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]