Subject: Re: [PATCH net-next 2/2] net: Fix offloading indirect devices dependency on qdisc order creation

From: kernel test robot <[email-masked]>
Date: Wed, 18 Aug 2021 02:19:17 +0800

Hi Eli,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eli-Cohen/Indirect-dev-ingress-qdisc-creation-order/20210817-212524
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 752be2976405b7499890c0b6bac6d30d34d08bd6
config: x86_64-randconfig-a011-20210816 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 2c6448cdc2f68f8c28fd0bd9404182b81306e6e6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8e304f96c15799e4618967e3a19cfd25fc9868de
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eli-Cohen/Indirect-dev-ingress-qdisc-creation-order/20210817-212524
        git checkout 8e304f96c15799e4618967e3a19cfd25fc9868de
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All warnings (new ones prefixed by >>):

>> net/core/flow_offload.c:365:20: warning: variable 'block' set but not used [-Wunused-but-set-variable]
           struct tcf_block *block;
                             ^
   1 warning generated.

vim +/block +365 net/core/flow_offload.c

   360	
   361	static void existing_qdiscs_register(flow_indr_block_bind_cb_t *cb, void *cb_priv)
   362	{
   363		struct flow_block_offload bo;
   364		struct flow_indir_dev_info *cur;
 > 365		struct tcf_block *block;
   366	
   367		list_for_each_entry(cur, &flow_indir_dev_list, list) {
   368			memset(&bo, 0, sizeof(bo));
   369			bo.command = cur->command;
   370			bo.binder_type = cur->binder_type;
   371			block = cur->data;
   372			INIT_LIST_HEAD(&bo.cb_list);
   373			cb(cur->dev, cur->sch, cb_priv, cur->type, &bo, cur->data, cur->cleanup);
   374			list_splice(&bo.cb_list, cur->cb_list);
   375		}
   376	}
   377	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]