From: kernel test robot <lkp@intel•com>
To: Sukadev Bhattiprolu <sukadev@linux•ibm.com>, netdev@vger•kernel.org
Cc: kbuild-all@lists•01.org, Brian King <brking@linux•ibm.com>,
cforno12@linux•ibm.com, Dany Madden <drt@linux•ibm.com>,
Rick Lindsley <ricklind@linux•ibm.com>
Subject: Re: [PATCH net-next 2/9] ibmvnic: Fix up some comments and messages
Date: Wed, 1 Sep 2021 16:58:15 +0800 [thread overview]
Message-ID: <202109011636.oMprno8L-lkp@intel.com> (raw)
In-Reply-To: <20210901000812.120968-3-sukadev@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2927 bytes --]
Hi Sukadev,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Sukadev-Bhattiprolu/ibmvnic-Reuse-ltb-rx-tx-pools/20210901-081123
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 29ce8f9701072fc221d9c38ad952de1a9578f95c
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a28141472dfbc71fb3b53b1ba9213b3450435588
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sukadev-Bhattiprolu/ibmvnic-Reuse-ltb-rx-tx-pools/20210901-081123
git checkout a28141472dfbc71fb3b53b1ba9213b3450435588
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel•com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/ibm/ibmvnic.c:579: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Release any rx_pools attached to @adapter.
drivers/net/ethernet/ibm/ibmvnic.c:752: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Release any tx and tso pools attached to @adapter.
vim +579 drivers/net/ethernet/ibm/ibmvnic.c
577
578 /**
> 579 * Release any rx_pools attached to @adapter.
580 * Safe to call this multiple times - even if no pools are attached.
581 */
582 static void release_rx_pools(struct ibmvnic_adapter *adapter)
583 {
584 struct ibmvnic_rx_pool *rx_pool;
585 int i, j;
586
587 if (!adapter->rx_pool)
588 return;
589
590 for (i = 0; i < adapter->num_active_rx_pools; i++) {
591 rx_pool = &adapter->rx_pool[i];
592
593 netdev_dbg(adapter->netdev, "Releasing rx_pool[%d]\n", i);
594
595 kfree(rx_pool->free_map);
596 free_long_term_buff(adapter, &rx_pool->long_term_buff);
597
598 if (!rx_pool->rx_buff)
599 continue;
600
601 for (j = 0; j < rx_pool->size; j++) {
602 if (rx_pool->rx_buff[j].skb) {
603 dev_kfree_skb_any(rx_pool->rx_buff[j].skb);
604 rx_pool->rx_buff[j].skb = NULL;
605 }
606 }
607
608 kfree(rx_pool->rx_buff);
609 }
610
611 kfree(adapter->rx_pool);
612 adapter->rx_pool = NULL;
613 adapter->num_active_rx_pools = 0;
614 }
615
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73419 bytes --]
next prev parent reply other threads:[~2021-09-01 8:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 0:08 [PATCH net-next 0/9] ibmvnic: Reuse ltb, rx, tx pools Sukadev Bhattiprolu
2021-09-01 0:08 ` [PATCH net-next 1/9] ibmvnic: Consolidate code in replenish_rx_pool() Sukadev Bhattiprolu
2021-09-01 1:26 ` Dany Madden
2021-09-01 0:08 ` [PATCH net-next 2/9] ibmvnic: Fix up some comments and messages Sukadev Bhattiprolu
2021-09-01 1:28 ` Dany Madden
2021-09-01 8:58 ` kernel test robot [this message]
2021-09-01 0:08 ` [PATCH net-next 3/9] ibmvnic: Use/rename local vars in init_rx_pools Sukadev Bhattiprolu
2021-09-01 1:28 ` Dany Madden
2021-09-01 0:08 ` [PATCH net-next 4/9] ibmvnic: Use/rename local vars in init_tx_pools Sukadev Bhattiprolu
2021-09-01 1:30 ` Dany Madden
2021-09-01 0:08 ` [PATCH net-next 5/9] ibmvnic: init_tx_pools move loop-invariant code out Sukadev Bhattiprolu
2021-09-01 1:32 ` Dany Madden
2021-09-01 0:08 ` [PATCH net-next 6/9] ibmvnic: Use bitmap for LTB map_ids Sukadev Bhattiprolu
2021-09-01 1:33 ` Dany Madden
2021-09-01 0:08 ` [PATCH net-next 7/9] ibmvnic: Reuse LTB when possible Sukadev Bhattiprolu
2021-09-01 1:34 ` Dany Madden
2021-09-01 0:08 ` [PATCH net-next 8/9] ibmvnic: Reuse rx pools " Sukadev Bhattiprolu
2021-09-01 1:35 ` Dany Madden
2021-09-01 0:08 ` [PATCH net-next 9/9] ibmvnic: Reuse tx " Sukadev Bhattiprolu
2021-09-01 1:36 ` Dany Madden
2021-09-01 1:21 ` [PATCH net-next 0/9] ibmvnic: Reuse ltb, rx, tx pools Rick Lindsley
2021-09-01 2:35 ` Jakub Kicinski
2021-09-01 18:07 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109011636.oMprno8L-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=brking@linux$(echo .)ibm.com \
--cc=cforno12@linux$(echo .)ibm.com \
--cc=drt@linux$(echo .)ibm.com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ricklind@linux$(echo .)ibm.com \
--cc=sukadev@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox