From: "Michael S. Tsirkin" <mst@redhat•com>
To: Xie Yongji <xieyongji@bytedance•com>
Cc: jasowang@redhat•com, stefanha@redhat•com, sgarzare@redhat•com,
parav@nvidia•com, hch@infradead•org,
christian.brauner@canonical•com, rdunlap@infradead•org,
willy@infradead•org, viro@zeniv•linux.org.uk, axboe@kernel•dk,
bcrl@kvack•org, corbet@lwn•net, mika.penttila@nextfour•com,
dan.carpenter@oracle•com, joro@8bytes•org,
gregkh@linuxfoundation•org, zhe.he@windriver•com,
xiaodong.liu@intel•com, joe@perches•com, robin.murphy@arm•com,
will@kernel•org, john.garry@huawei•com, songmuchun@bytedance•com,
virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, kvm@vger•kernel.org,
linux-fsdevel@vger•kernel.org, iommu@lists•linux-foundation.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v13 03/13] file: Export receive_fd() to modules
Date: Sun, 5 Sep 2021 11:57:22 -0400 [thread overview]
Message-ID: <20210905115642-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210831103634.33-4-xieyongji@bytedance.com>
On Tue, Aug 31, 2021 at 06:36:24PM +0800, Xie Yongji wrote:
> Export receive_fd() so that some modules can use
> it to pass file descriptor between processes without
> missing any security stuffs.
>
> Signed-off-by: Xie Yongji <xieyongji@bytedance•com>
> Acked-by: Jason Wang <jasowang@redhat•com>
This needs some acks from fs devels.
Viro?
> ---
> fs/file.c | 6 ++++++
> include/linux/file.h | 7 +++----
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/fs/file.c b/fs/file.c
> index 86dc9956af32..210e540672aa 100644
> --- a/fs/file.c
> +++ b/fs/file.c
> @@ -1134,6 +1134,12 @@ int receive_fd_replace(int new_fd, struct file *file, unsigned int o_flags)
> return new_fd;
> }
>
> +int receive_fd(struct file *file, unsigned int o_flags)
> +{
> + return __receive_fd(file, NULL, o_flags);
> +}
> +EXPORT_SYMBOL_GPL(receive_fd);
> +
> static int ksys_dup3(unsigned int oldfd, unsigned int newfd, int flags)
> {
> int err = -EBADF;
> diff --git a/include/linux/file.h b/include/linux/file.h
> index 2de2e4613d7b..51e830b4fe3a 100644
> --- a/include/linux/file.h
> +++ b/include/linux/file.h
> @@ -94,6 +94,9 @@ extern void fd_install(unsigned int fd, struct file *file);
>
> extern int __receive_fd(struct file *file, int __user *ufd,
> unsigned int o_flags);
> +
> +extern int receive_fd(struct file *file, unsigned int o_flags);
> +
> static inline int receive_fd_user(struct file *file, int __user *ufd,
> unsigned int o_flags)
> {
> @@ -101,10 +104,6 @@ static inline int receive_fd_user(struct file *file, int __user *ufd,
> return -EFAULT;
> return __receive_fd(file, ufd, o_flags);
> }
> -static inline int receive_fd(struct file *file, unsigned int o_flags)
> -{
> - return __receive_fd(file, NULL, o_flags);
> -}
> int receive_fd_replace(int new_fd, struct file *file, unsigned int o_flags);
>
> extern void flush_delayed_fput(void);
> --
> 2.11.0
next prev parent reply other threads:[~2021-09-05 15:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 10:36 [PATCH v13 00/13] Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-08-31 10:36 ` [PATCH v13 01/13] iova: Export alloc_iova_fast() and free_iova_fast() Xie Yongji
2021-08-31 10:36 ` [PATCH v13 02/13] eventfd: Export eventfd_wake_count to modules Xie Yongji
2021-09-01 2:50 ` Jason Wang
2021-08-31 10:36 ` [PATCH v13 03/13] file: Export receive_fd() " Xie Yongji
2021-09-05 15:57 ` Michael S. Tsirkin [this message]
2021-09-05 16:44 ` Al Viro
2021-08-31 10:36 ` [PATCH v13 04/13] vdpa: Fix some coding style issues Xie Yongji
2021-08-31 10:36 ` [PATCH v13 05/13] vdpa: Add reset callback in vdpa_config_ops Xie Yongji
2021-09-06 5:55 ` Michael S. Tsirkin
2021-09-06 6:09 ` Yongji Xie
2021-09-06 6:37 ` Michael S. Tsirkin
2021-09-06 7:06 ` Yongji Xie
2021-09-06 8:00 ` Michael S. Tsirkin
2021-09-06 8:45 ` Yongji Xie
2021-09-06 10:43 ` Michael S. Tsirkin
2021-09-06 12:13 ` Yongji Xie
2021-08-31 10:36 ` [PATCH v13 06/13] vhost-vdpa: Handle the failure of vdpa_reset() Xie Yongji
2021-08-31 10:36 ` [PATCH v13 07/13] vhost-iotlb: Add an opaque pointer for vhost IOTLB Xie Yongji
2021-08-31 10:36 ` [PATCH v13 08/13] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map() Xie Yongji
2021-08-31 10:36 ` [PATCH v13 09/13] vdpa: factor out vhost_vdpa_pa_map() and vhost_vdpa_pa_unmap() Xie Yongji
2021-08-31 10:36 ` [PATCH v13 10/13] vdpa: Support transferring virtual addressing during DMA mapping Xie Yongji
2021-08-31 10:36 ` [PATCH v13 11/13] vduse: Implement an MMU-based software IOTLB Xie Yongji
2021-08-31 10:36 ` [PATCH v13 12/13] vduse: Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-08-31 10:36 ` [PATCH v13 13/13] Documentation: Add documentation for VDUSE Xie Yongji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210905115642-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=bcrl@kvack$(echo .)org \
--cc=christian.brauner@canonical$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hch@infradead$(echo .)org \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jasowang@redhat$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=john.garry@huawei$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mika.penttila@nextfour$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=parav@nvidia$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=sgarzare@redhat$(echo .)com \
--cc=songmuchun@bytedance$(echo .)com \
--cc=stefanha@redhat$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=will@kernel$(echo .)org \
--cc=willy@infradead$(echo .)org \
--cc=xiaodong.liu@intel$(echo .)com \
--cc=xieyongji@bytedance$(echo .)com \
--cc=zhe.he@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox