Subject: Re: [PATCH v2 net] net: qrtr: make checks in qrtr_endpoint_post() stricter

From: Dan Carpenter <[email-masked]>
Date: Mon, 6 Sep 2021 09:53:20 +0300

On Fri, Sep 03, 2021 at 07:29:28PM +0000, Yassine Oudjana wrote:
>  > if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
>  > @@ -506,8 +506,12 @@ int qrtr_endpoint_post(struct qrtr_endpoint 
> *ep, const void *data, size_t len)
>  >
>  > if (cb->type == QRTR_TYPE_NEW_SERVER) {
>  > /* Remote node endpoint can bridge other distant nodes */
>  > - const struct qrtr_ctrl_pkt *pkt = data + hdrlen;
>  > + const struct qrtr_ctrl_pkt *pkt;
>  >
>  > + if (size < sizeof(*pkt))
>  > + goto err;
>  > +
>  > + pkt = data + hdrlen;
>  > qrtr_node_assign(node, le32_to_cpu(pkt->server.node));
>  > }
>  >
>  > --
>  > 2.20.1
>  >
> 
> This is crashing MSM8996. I get these messages (dmesg | grep 
> remoteproc):

Yes.  I apologize for that.  The fix has been merged already.

regards,
dan carpenter