From: Stephen Hemminger <stephen@networkplumber•org>
To: Thorsten Glaser <t.glaser@tarent•de>
Cc: Wen Liang <liangwen12year@gmail•com>,
netdev@vger•kernel.org, dsahern@gmail•com, aclaudi@redhat•com
Subject: Re: [PATCH iproute2 1/2] tc: u32: add support for json output
Date: Tue, 7 Sep 2021 13:55:48 -0700 [thread overview]
Message-ID: <20210907135548.01bab77e@hermes.local> (raw)
In-Reply-To: <f9752b7-476-5ae6-6ab4-717e1c8553bb@tarent.de>
On Tue, 7 Sep 2021 21:32:41 +0200 (CEST)
Thorsten Glaser <t.glaser@tarent•de> wrote:
> On Tue, 7 Sep 2021, Stephen Hemminger wrote:
>
> > Space is not valid in JSON tag.
>
> They are valid. Any strings are valid.
Your right the library is quoting them, but various style guidelines
do not recommend doing this.
next prev parent reply other threads:[~2021-09-07 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 1:57 [PATCH iproute2 0/2] add json support on tc u32 Wen Liang
2021-09-07 1:57 ` [PATCH iproute2 1/2] tc: u32: add support for json output Wen Liang
2021-09-07 15:46 ` Davide Caratti
2021-09-07 19:29 ` Stephen Hemminger
2021-09-07 19:32 ` Thorsten Glaser
2021-09-07 20:55 ` Stephen Hemminger [this message]
2021-09-08 1:18 ` David Ahern
2021-09-07 1:57 ` [PATCH iproute2 2/2] tc: u32: add json support in `print_raw`, `print_ipv4`, `print_ipv6` Wen Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907135548.01bab77e@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=aclaudi@redhat$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=liangwen12year@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=t.glaser@tarent$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox