From: DENG Qingfang <dqfext@gmail•com>
To: Linus Walleij <linus.walleij@linaro•org>
Cc: Andrew Lunn <andrew@lunn•ch>,
Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Vladimir Oltean <olteanv@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames
Date: Wed, 15 Sep 2021 15:19:01 +0800 [thread overview]
Message-ID: <20210915071901.1315-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210913143156.1264570-1-linus.walleij@linaro.org>
On Mon, Sep 13, 2021 at 04:31:56PM +0200, Linus Walleij wrote:
> This drops the code setting bit 9 on egress frames on the
> Realtek "type A" (RTL8366RB) frames.
FYI, on RTL8366S, bit 9 on egress frames is disable learning.
> This bit was set on ingress frames for unknown reason,
I think it could be the reason why the frame is forwarded to the CPU.
> and was set on egress frames as the format of ingress
> and egress frames was believed to be the same. As that
> assumption turned out to be false, and since this bit
> seems to have zero effect on the behaviour of the switch
> let's drop this bit entirely.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro•org>
next prev parent reply other threads:[~2021-09-15 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:31 [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames Linus Walleij
2021-09-13 16:05 ` Andrew Lunn
2021-09-13 16:06 ` Florian Fainelli
2021-09-15 3:10 ` patchwork-bot+netdevbpf
2021-09-15 7:19 ` DENG Qingfang [this message]
2021-09-23 21:59 ` Linus Walleij
2021-09-23 22:12 ` Vladimir Oltean
2021-09-23 22:21 ` Linus Walleij
2021-09-23 22:25 ` Vladimir Oltean
2021-09-23 22:58 ` Linus Walleij
2021-09-23 23:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915071901.1315-1-dqfext@gmail.com \
--to=dqfext@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox