Subject: Re: [PATCH net-next] sky2: Stop printing VPD info to debugfs

From: Stephen Hemminger <[email-masked]>
Date: Thu, 16 Sep 2021 15:13:59 -0700

On Thu, 16 Sep 2021 23:40:37 +0200
Heiner Kallweit <[email-masked]> wrote:

> Sky2 is parsing the VPD and adds the parsed information to its debugfs
> file. This isn't needed in kernel, userspace tools like lspci can be
> used to display such information nicely. Therefore remove this from
> the driver.
> 
> lspci -vv:
> 
> Capabilities: [50] Vital Product Data
> 	Product Name: Marvell Yukon 88E8070 Gigabit Ethernet Controller
> 	Read-only fields:
> 		[PN] Part number: Yukon 88E8070
> 		[EC] Engineering changes: Rev. 1.0
> 		[MN] Manufacture ID: Marvell
> 		[SN] Serial number: AbCdEfG970FD4
> 		[CP] Extended capability: 01 10 cc 03
> 		[RV] Reserved: checksum good, 9 byte(s) reserved
> 	Read/write fields:
> 		[RW] Read-write area: 1 byte(s) free
> 	End
> 
> Relevant part in debugfs file:
> 
> 0000:01:00.0 Product Data
> Marvell Yukon 88E8070 Gigabit Ethernet Controller
>  Part Number: Yukon 88E8070
>  Engineering Level: Rev. 1.0
>  Manufacturer: Marvell
>  Serial Number: AbCdEfG970FD4
> 
> Signed-off-by: Heiner Kallweit <[email-masked]>

Make sense lspci seems to have gotten better at handling this now.

Acked-by: Stephen Hemminger <[email-masked]>