public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: "yajun.deng@linux•dev" <yajun.deng@linux•dev>
To: "Cong Wang" <xiyou.wangcong@gmail•com>
Cc: kuba <kuba@kernel•org>, davem <davem@davemloft•net>,
	netdev <netdev@vger•kernel.org>,
	linux-kernel <linux-kernel@vger•kernel.org>
Subject: Re: Re: [PATCH net-next] net: socket: add the case sock_no_xxx support
Date: Mon, 20 Sep 2021 20:28:18 +0800	[thread overview]
Message-ID: <202109202028152977817@linux.dev> (raw)
In-Reply-To: CAM_iQpXcqpEFpnyX=wLQFTWJBjWiAMofighQkpnrV2a0Fh83AQ@mail.gmail.com

From: Cong Wang
Date: 2021-09-20 07:52
To: Yajun Deng
CC: Jakub Kicinski; David Miller; Linux Kernel Network Developers; LKML
Subject: Re: [PATCH net-next] net: socket: add the case sock_no_xxx support
On Sat, Sep 18, 2021 at 5:11 AM <yajun.deng@linux•dev> wrote:
>
> September 18, 2021 9:33 AM, "Jakub Kicinski" <kuba@kernel•org> wrote:
>
> > On Thu, 16 Sep 2021 20:29:43 +0800 Yajun Deng wrote:
> >
> >> Those sock_no_{mmap, socketpair, listen, accept, connect, shutdown,
> >> sendpage} functions are used many times in struct proto_ops, but they are
> >> meaningless. So we can add them support in socket and delete them in struct
> >> proto_ops.
> >
> > So the reason to do this is.. what exactly?
> >
> > Removing a couple empty helpers (which is not even part of this patch)?
> >
> > I'm not sold, sorry.
>
> When we define a struct proto_ops xxx, we only need to assign meaningful member variables that we need.
> Those {mmap, socketpair, listen, accept, connect, shutdown, sendpage} members we don't need assign
> it if we don't need. We just need do once in socket, not in every struct proto_ops.
>
> These members are assigned meaningless values far more often than meaningful ones, so this patch I used likely(!!sock->ops->xxx) for this case. This is the reason why I send this patch.
 
But you end up adding more code:
 
1 file changed, 58 insertions(+), 13 deletions(-) 

Yes，This would add more code, but this is at the cost of reducing other codes. At the same time, the code will only run  likely(!sock->ops->xxx) in most cases.  Don’t you think that this kind of meaningless thing shouldn’t be done by socket?
 
I don't see this as a gain from any perspective.
 
Thanks.

next prev parent reply	other threads:[~2021-09-20 12:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 12:29 [PATCH net-next] net: socket: add the case sock_no_xxx support Yajun Deng
2021-09-18  1:33 ` Jakub Kicinski
2021-09-18  2:53   ` yajun.deng
2021-09-19 23:52     ` Cong Wang
2021-09-20 12:28       ` yajun.deng [this message]
2021-09-20 16:33         ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109202028152977817@linux.dev \
    --to=yajun.deng@linux$(echo .)dev \
    --cc=davem@davemloft$(echo .)net \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=xiyou.wangcong@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox