From: "yajun.deng@linux•dev" <yajun.deng@linux•dev>
To: "Cong Wang" <xiyou.wangcong@gmail•com>
Cc: davem <davem@davemloft•net>, kuba <kuba@kernel•org>,
netdev <netdev@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>
Subject: Re: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()
Date: Mon, 20 Sep 2021 20:29:36 +0800 [thread overview]
Message-ID: <202109202029339411609@linux.dev> (raw)
In-Reply-To: CAM_iQpW8hGBinQKTqKidYfn5sJjAYMUMHyr4U-=dn_CfWVLtMQ@mail.gmail.com
From: Cong Wang
Date: 2021-09-20 07:25
To: Yajun Deng
CC: David Miller; Jakub Kicinski; Linux Kernel Network Developers; LKML
Subject: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()
On Sat, Sep 18, 2021 at 7:28 AM Yajun Deng <yajun.deng@linux•dev> wrote:
>
> The key_domain member in struct net only exists if we define CONFIG_KEYS.
> So we should add the define when we used key_domain.
But key_remove_domain() is just a nop if !CONFIG_KEYS:
#else /* CONFIG_KEYS */
...
#define key_remove_domain(d) do { } while(0)
Yes, you're right.
So what exactly are you fixing?
Thanks.
prev parent reply other threads:[~2021-09-20 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 9:04 [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain() Yajun Deng
2021-09-19 11:50 ` patchwork-bot+netdevbpf
2021-09-19 23:25 ` Cong Wang
2021-09-20 12:29 ` yajun.deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109202029339411609@linux.dev \
--to=yajun.deng@linux$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox