Subject: Re: [PATCH v2] rsi: Fix module dev_oper_mode parameter description

From: Kalle Valo <[email-masked]>
Date: Tue, 21 Sep 2021 15:04:20 +0000 (UTC)

Marek Vasut <[email-masked]> wrote:

> The module parameters are missing dev_oper_mode 12, BT classic alone,
> add it. Moreover, the parameters encode newlines, which ends up being
> printed malformed e.g. by modinfo, so fix that too.
> 
> However, the module parameter string is duplicated in both USB and SDIO
> modules and the dev_oper_mode mode enumeration in those module parameters
> is a duplicate of macros used by the driver. Furthermore, the enumeration
> is confusing.
> 
> So, deduplicate the module parameter string and use __stringify() to
> encode the correct mode enumeration values into the module parameter
> string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with
> 'BT classic alone' to clarify what those modes really mean.
> 
> Fixes: 898b255339310 ("rsi: add module parameter operating mode")
> Signed-off-by: Marek Vasut <[email-masked]>
> Cc: Amitkumar Karwar <[email-masked]>
> Cc: Angus Ainslie <[email-masked]>
> Cc: David S. Miller <[email-masked]>
> Cc: Jakub Kicinski <[email-masked]>
> Cc: Kalle Valo <[email-masked]>
> Cc: Karun Eagalapati <[email-masked]>
> Cc: Martin Fuzzey <[email-masked]>
> Cc: Martin Kepplinger <[email-masked]>
> Cc: Prameela Rani Garnepudi <[email-masked]>
> Cc: Sebastian Krzyszkowiak <[email-masked]>
> Cc: Siva Rebbagondla <[email-masked]>
> Cc: [email-masked]
> Cc: <[email-masked]> # 4.17+

Patch applied to wireless-drivers-next.git, thanks.

31f97cf9f0c3 rsi: Fix module dev_oper_mode parameter description

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/[email-masked]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches