From: Christoph Hellwig <hch@lst•de>
To: Tianyu Lan <ltykernel@gmail•com>
Cc: Christoph Hellwig <hch@lst•de>,
"iommu@lists•linux-foundation.org"
<iommu@lists•linux-foundation.org>,
"linux-arch@vger•kernel.org" <linux-arch@vger•kernel.org>,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-scsi@vger•kernel.org" <linux-scsi@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
vkuznets <vkuznets@redhat•com>,
"parri.andrea@gmail•com" <parri.andrea@gmail•com>,
"dave.hansen@intel•com" <dave.hansen@intel•com>,
Michael Kelley <mikelley@microsoft•com>,
KY Srinivasan <kys@microsoft•com>,
Haiyang Zhang <haiyangz@microsoft•com>,
Stephen Hemminger <sthemmin@microsoft•com>,
"wei.liu@kernel•org" <wei.liu@kernel•org>,
Dexuan Cui <decui@microsoft•com>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"mingo@redhat•com" <mingo@redhat•com>,
"bp@alien8•de" <bp@alien8•de>, "x86@kernel•org" <x86@kernel•org>,
"hpa@zytor•com" <hpa@zytor•com>,
"dave.hansen@linux•intel.com" <dave.hansen@linux•intel.com>,
"luto@kernel•org" <luto@kernel•org>,
"peterz@infradead•org" <peterz@infradead•org>,
"konrad.wilk@oracle•com" <konrad.wilk@oracle•com>,
"boris.ostrovsky@oracle•com" <boris.ostrovsky@oracle•com>,
"jgross@suse•com" <jgross@suse•com>,
"sstabellini@kernel•org" <sstabellini@kernel•org>,
"joro@8bytes•org" <joro@8bytes•org>,
"will@kernel•org" <will@kernel•org>,
"davem@davemloft•net" <davem@davemloft•net>,
"kuba@kernel•org" <kuba@kernel•org>,
"jejb@linux•ibm.com" <jejb@linux•ibm.com>,
"martin.petersen@oracle•com" <martin.petersen@oracle•com>,
"gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>,
"arnd@arndb•de" <arnd@arndb•de>,
"m.szyprowski@samsung•com" <m.szyprowski@samsung•com>,
"robin.murphy@arm•com" <robin.murphy@arm•com>,
"brijesh.singh@amd•com" <brijesh.singh@amd•com>,
Tianyu Lan <Tianyu.Lan@microsoft•com>,
"thomas.lendacky@amd•com" <thomas.lendacky@amd•com>,
"pgonda@google•com" <pgonda@google•com>,
"akpm@linux-foundation•org" <akpm@linux-foundation•org>,
"kirill.shutemov@linux•intel.com"
<kirill.shutemov@linux•intel.com>,
"rppt@kernel•org" <rppt@kernel•org>,
"sfr@canb•auug.org.au" <sfr@canb•auug.org.au>,
"aneesh.kumar@linux•ibm.com" <aneesh.kumar@linux•ibm.com>,
"saravanand@fb•com" <saravanand@fb•com>,
"krish.sadhukhan@oracle•com" <krish.sadhukhan@oracle•com>,
"xen-devel@lists•xenproject.org" <xen-devel@lists•xenproject.org>,
"tj@kernel•org" <tj@kernel•org>,
"rientjes@google•com" <rientjes@google•com>
Subject: Re: [PATCH V5 12/12] net: netvsc: Add Isolation VM support for netvsc driver
Date: Tue, 28 Sep 2021 07:39:11 +0200 [thread overview]
Message-ID: <20210928053911.GA29208@lst.de> (raw)
In-Reply-To: <e379a60b-4d74-9167-983f-f70c96bb279e@gmail.com>
On Mon, Sep 27, 2021 at 10:26:43PM +0800, Tianyu Lan wrote:
> Hi Christoph:
> Gentile ping. The swiotlb and shared memory mapping changes in this
> patchset needs your reivew. Could you have a look?
I'm a little too busy for a review of such a huge patchset right now.
That being said here are my comments from a very quick review:
- the bare memremap usage in swiotlb looks strange and I'd
definitively expect a well documented wrapper.
- given that we can now hand out swiotlb memory for coherent mappings
we need to carefully audit what happens when this memremaped
memory gets mmaped or used through dma_get_sgtable
- the netscv changes I'm not happy with at all. A large part of it
is that the driver already has a bad structure, but this series
is making it significantly worse. We'll need to find a way
to use the proper dma mapping abstractions here. One option
if you want to stick to the double vmapped buffer would be something
like using dma_alloc_noncontigous plus a variant of
dma_vmap_noncontiguous that takes the shared_gpa_boundary into
account.
next prev parent reply other threads:[~2021-09-28 5:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 13:39 [PATCH V5 00/12] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 01/12] x86/hyperv: Initialize GHCB page in Isolation VM Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 02/12] x86/hyperv: Initialize shared memory boundary in the " Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 03/12] x86/hyperv: Add new hvcall guest address host visibility support Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 04/12] Drivers: hv: vmbus: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan
2021-09-15 15:40 ` Michael Kelley
2021-09-14 13:39 ` [PATCH V5 05/12] x86/hyperv: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-09-15 15:41 ` Michael Kelley
2021-09-14 13:39 ` [PATCH V5 06/12] x86/hyperv: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 07/12] Drivers: hv: vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-09-15 15:41 ` Michael Kelley
2021-09-16 10:52 ` Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 08/12] Drivers: hv : vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 09/12] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-09-15 15:42 ` Michael Kelley
2021-09-16 10:57 ` Tianyu Lan
2021-09-14 13:39 ` [PATCH V5 10/12] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-09-15 15:43 ` Michael Kelley
2021-09-14 13:39 ` [PATCH V5 11/12] scsi: storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-09-15 15:43 ` Michael Kelley
2021-09-14 13:39 ` [PATCH V5 12/12] net: netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-09-14 15:49 ` Haiyang Zhang
2021-09-15 16:21 ` Michael Kelley
2021-09-15 16:46 ` Haiyang Zhang
2021-09-16 13:56 ` Tianyu Lan
2021-09-16 14:43 ` Tianyu Lan
2021-09-22 10:34 ` Tianyu Lan
2021-09-27 14:26 ` Tianyu Lan
2021-09-28 5:39 ` Christoph Hellwig [this message]
2021-09-28 9:23 ` Tianyu Lan
2021-09-30 5:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928053911.GA29208@lst.de \
--to=hch@lst$(echo .)de \
--cc=Tianyu.Lan@microsoft$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=arnd@arndb$(echo .)de \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brijesh.singh@amd$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jgross@suse$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=krish.sadhukhan@oracle$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=ltykernel@gmail$(echo .)com \
--cc=luto@kernel$(echo .)org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mikelley@microsoft$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=parri.andrea@gmail$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pgonda@google$(echo .)com \
--cc=rientjes@google$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=saravanand@fb$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sstabellini@kernel$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=tj@kernel$(echo .)org \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox