From: Dan Carpenter <dan.carpenter@oracle•com>
To: Leon Romanovsky <leon@kernel•org>
Cc: "David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Leon Romanovsky <leonro@nvidia•com>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
Andrew Lunn <andrew@lunn•ch>, Ariel Elior <aelior@marvell•com>,
Bin Luo <luobin9@huawei•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Coiby Xu <coiby.xu@gmail•com>,
Derek Chickles <dchickles@marvell•com>,
drivers@pensando•io, Eric Dumazet <eric.dumazet@gmail•com>,
Felix Manlunas <fmanlunas@marvell•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Geetha sowjanya <gakula@marvell•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
GR-everest-linux-l2@marvell•com, GR-Linux-NIC-Dev@marvell•com,
hariprasad <hkelam@marvell•com>, Ido Schimmel <idosch@nvidia•com>,
intel-wired-lan@lists•osuosl.org,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Jerin Jacob <jerinj@marvell•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Jiri Pirko <jiri@nvidia•com>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
Linu Cherian <lcherian@marvell•com>,
linux-kernel@vger•kernel.org, linux-omap@vger•kernel.org,
linux-rdma@vger•kernel.org, linux-staging@lists•linux.dev,
Manish Chopra <manishc@marvell•com>,
Michael Chan <michael.chan@broadcom•com>,
Moshe Shemesh <moshe@nvidia•com>,
netdev@vger•kernel.org, oss-drivers@corigine•com,
Richard Cochran <richardcochran@gmail•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Salil Mehta <salil.mehta@huawei•com>,
Satanand Burla <sburla@marvell•com>,
Shannon Nelson <snelson@pensando•io>,
Shay Drory <shayd@nvidia•com>,
Simon Horman <simon.horman@corigine•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Sunil Goutham <sgoutham@marvell•com>,
Taras Chornyi <tchornyi@marvell•com>,
Tariq Toukan <tariqt@nvidia•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
UNGLinuxDriver@microchip•com, Vadym Kochan <vkochan@marvell•com>,
Vivien Didelot <vivien.didelot@gmail•com>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Yisen Zhuang <yisen.zhuang@huawei•com>
Subject: Re: [PATCH net-next 3/5] devlink: Allow set specific ops callbacks dynamically
Date: Wed, 29 Sep 2021 13:38:23 +0300 [thread overview]
Message-ID: <20210929103823.GK2048@kadam> (raw)
In-Reply-To: <4e99e3996118ce0e2da5367b8fc2a427095dfffd.1632909221.git.leonro@nvidia.com>
On Wed, Sep 29, 2021 at 01:16:37PM +0300, Leon Romanovsky wrote:
> +void devlink_set_ops(struct devlink *devlink, struct devlink_ops *ops)
> +{
> + struct devlink_ops *dev_ops = devlink->ops;
> +
> + WARN_ON(!devlink_reload_actions_valid(ops));
> +
> +#define SET_DEVICE_OP(ptr, name) \
> + do { \
> + if (ops->name) \
Could you make "ops" a parameter of the macro instead of hard coding it?
regards,
dan carpenter
> + if (!((ptr)->name)) \
> + (ptr)->name = ops->name; \
> + } while (0)
> +
> + /* Keep sorted */
> + SET_DEVICE_OP(dev_ops, reload_actions);
> + SET_DEVICE_OP(dev_ops, reload_down);
> + SET_DEVICE_OP(dev_ops, reload_limits);
> + SET_DEVICE_OP(dev_ops, reload_up);
> +
> +#undef SET_DEVICE_OP
> +}
> +EXPORT_SYMBOL_GPL(devlink_set_ops);
next prev parent reply other threads:[~2021-09-29 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 10:16 [PATCH net-next 0/5] Devlink reload and missed notifications fix Leon Romanovsky
2021-09-29 10:16 ` [PATCH net-next 1/5] devlink: Add missed notifications iterators Leon Romanovsky
2021-09-29 10:16 ` [PATCH net-next 2/5] devlink: Allow modification of devlink ops Leon Romanovsky
2021-09-29 10:20 ` Simon Horman
2021-09-29 10:16 ` [PATCH net-next 3/5] devlink: Allow set specific ops callbacks dynamically Leon Romanovsky
2021-09-29 10:38 ` Dan Carpenter [this message]
2021-09-29 10:43 ` Leon Romanovsky
2021-09-29 10:16 ` [PATCH net-next 4/5] net/mlx5: Register separate reload devlink ops for multiport device Leon Romanovsky
2021-09-29 10:16 ` [PATCH net-next 5/5] devlink: Delete reload enable/disable interface Leon Romanovsky
2021-09-29 10:40 ` [PATCH net-next 0/5] Devlink reload and missed notifications fix Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929103823.GK2048@kadam \
--to=dan.carpenter@oracle$(echo .)com \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=GR-everest-linux-l2@marvell$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=coiby.xu@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dchickles@marvell$(echo .)com \
--cc=drivers@pensando$(echo .)io \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fmanlunas@marvell$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hkelam@marvell$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=jerinj@marvell$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lcherian@marvell$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=leonro@nvidia$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=luobin9@huawei$(echo .)com \
--cc=manishc@marvell$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=moshe@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sburla@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shayd@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=snelson@pensando$(echo .)io \
--cc=tariqt@nvidia$(echo .)com \
--cc=tchornyi@marvell$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vkochan@marvell$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox