From: Jason Gunthorpe <jgg@nvidia•com>
To: Leon Romanovsky <leon@kernel•org>
Cc: Doug Ledford <dledford@redhat•com>,
Aharon Landau <aharonl@nvidia•com>,
"David S. Miller" <davem@davemloft•net>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks•com>,
Gal Pressman <galpress@amazon•com>,
Jakub Kicinski <kuba@kernel•org>,
linux-kernel@vger•kernel.org, linux-rdma@vger•kernel.org,
Maor Gottlieb <maorg@nvidia•com>,
Mark Zhang <markzhang@nvidia•com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks•com>,
Mustafa Ismail <mustafa.ismail@intel•com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom•com>,
Neta Ostrovsky <netao@nvidia•com>,
netdev@vger•kernel.org, Potnuri Bharat Teja <bharat@chelsio•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Selvin Xavier <selvin.xavier@broadcom•com>,
Shiraz Saleem <shiraz.saleem@intel•com>,
Yishai Hadas <yishaih@nvidia•com>,
Zhu Yanjun <zyjzyj2000@gmail•com>
Subject: Re: [PATCH rdma-next v2 06/13] RDMA/counter: Add optional counter support
Date: Mon, 4 Oct 2021 15:01:24 -0300 [thread overview]
Message-ID: <20211004180124.GC2515663@nvidia.com> (raw)
In-Reply-To: <f473f52f9ba462112df91866aa5cf08687008c58.1632988543.git.leonro@nvidia.com>
On Thu, Sep 30, 2021 at 11:02:22AM +0300, Leon Romanovsky wrote:
> diff --git a/drivers/infiniband/core/counters.c b/drivers/infiniband/core/counters.c
> index 331cd29f0d61..dac8f370ae3c 100644
> +++ b/drivers/infiniband/core/counters.c
> @@ -106,6 +106,36 @@ static int __rdma_counter_bind_qp(struct rdma_counter *counter,
> return ret;
> }
>
> +int rdma_counter_modify(struct ib_device *dev, u32 port,
> + unsigned int index, bool enable)
> +{
> + struct rdma_hw_stats *stats;
> + int ret = 0;
> +
> + if (!dev->ops.modify_hw_stat)
> + return -EOPNOTSUPP;
> +
> + stats = ib_get_hw_stats_port(dev, port);
> + if (!stats || (index >= stats->num_counters) ||
> + !(stats->descs[index].flags & IB_STAT_FLAG_OPTIONAL))
> + return -EINVAL;
> +
> + mutex_lock(&stats->lock);
> +
> + if (enable != test_bit(index, stats->is_disabled))
> + goto out;
> +
> + ret = dev->ops.modify_hw_stat(dev, port, index, enable);
> + if (ret)
> + goto out;
> +
> + enable ? clear_bit(index, stats->is_disabled) :
> + set_bit(index, stats->is_disabled);
This still needs to follow the kernel standard..
Jason
next prev parent reply other threads:[~2021-10-04 18:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 8:02 [PATCH rdma-next v2 00/13] Optional counter statistics support Leon Romanovsky
2021-09-30 8:02 ` [PATCH mlx5-next v2 01/13] net/mlx5: Add ifc bits to support optional counters Leon Romanovsky
2021-09-30 8:02 ` [PATCH mlx5-next v2 02/13] net/mlx5: Add priorities for counters in RDMA namespaces Leon Romanovsky
2021-09-30 8:02 ` [PATCH rdma-next v2 03/13] RDMA/counter: Add a descriptor in struct rdma_hw_stats Leon Romanovsky
2021-09-30 8:02 ` [PATCH rdma-next v2 04/13] RDMA/core: Add a helper API rdma_free_hw_stats_struct Leon Romanovsky
2021-10-04 17:59 ` Jason Gunthorpe
2021-09-30 8:02 ` [PATCH rdma-next v2 05/13] RDMA/counter: Add an is_disabled field in struct rdma_hw_stats Leon Romanovsky
2021-10-04 18:00 ` Jason Gunthorpe
2021-09-30 8:02 ` [PATCH rdma-next v2 06/13] RDMA/counter: Add optional counter support Leon Romanovsky
2021-10-04 18:01 ` Jason Gunthorpe [this message]
2021-09-30 8:02 ` [PATCH rdma-next v2 07/13] RDMA/nldev: Add support to get status of all counters Leon Romanovsky
2021-09-30 8:02 ` [PATCH rdma-next v2 08/13] RDMA/nldev: Allow optional-counter status configuration through RDMA netlink Leon Romanovsky
2021-10-04 18:03 ` Jason Gunthorpe
2021-09-30 8:02 ` [PATCH rdma-next v2 09/13] RDMA/mlx5: Support optional counters in hw_stats initialization Leon Romanovsky
2021-09-30 8:02 ` [PATCH rdma-next v2 10/13] RDMA/mlx5: Add steering support in optional flow counters Leon Romanovsky
2021-09-30 8:02 ` [PATCH rdma-next v2 11/13] RDMA/mlx5: Add modify_op_stat() support Leon Romanovsky
2021-09-30 8:02 ` [PATCH rdma-next v2 12/13] RDMA/mlx5: Add optional counter support in get_hw_stats callback Leon Romanovsky
2021-09-30 8:02 ` [PATCH rdma-next v2 13/13] RDMA/nldev: Add support to get status of all counters Leon Romanovsky
2021-10-04 18:07 ` Jason Gunthorpe
2021-10-05 11:00 ` Leon Romanovsky
2021-10-04 18:11 ` [PATCH rdma-next v2 00/13] Optional counter statistics support Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004180124.GC2515663@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=aharonl@nvidia$(echo .)com \
--cc=bharat@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dennis.dalessandro@cornelisnetworks$(echo .)com \
--cc=dledford@redhat$(echo .)com \
--cc=galpress@amazon$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=maorg@nvidia$(echo .)com \
--cc=markzhang@nvidia$(echo .)com \
--cc=mike.marciniszyn@cornelisnetworks$(echo .)com \
--cc=mustafa.ismail@intel$(echo .)com \
--cc=nareshkumar.pbs@broadcom$(echo .)com \
--cc=netao@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@nvidia$(echo .)com \
--cc=selvin.xavier@broadcom$(echo .)com \
--cc=shiraz.saleem@intel$(echo .)com \
--cc=yishaih@nvidia$(echo .)com \
--cc=zyjzyj2000@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox