Subject: Re: [PATCH net-next 1/7] ethernet: constify references to netdev->dev_addr in drivers

From: kernel test robot <[email-masked]>
Date: Thu, 14 Oct 2021 14:15:14 +0800

Hi Jakub,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethernet-more-netdev-dev_addr-write-removals/20211014-045931
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5f3b8acee9fee04ece54376a4f842847000a97f3
config: i386-randconfig-a015-20211013 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/6ead16677b0e7c54f6a7679276c70ffa1bbc17f3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jakub-Kicinski/ethernet-more-netdev-dev_addr-write-removals/20211014-045931
        git checkout 6ead16677b0e7c54f6a7679276c70ffa1bbc17f3
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/broadcom/bnxt/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1249:5: error: conflicting types for 'bnxt_approve_mac'
    1249 | int bnxt_approve_mac(struct bnxt *bp, u8 *mac, bool strict)
         |     ^~~~~~~~~~~~~~~~
   In file included from drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:22:
   drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h:44:5: note: previous declaration of 'bnxt_approve_mac' was here
      44 | int bnxt_approve_mac(struct bnxt *, const u8 *, bool);
         |     ^~~~~~~~~~~~~~~~

vim +/bnxt_approve_mac +1249 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c

84c33dd342ad59 Michael Chan 2016-04-11  1248  
28ea334bd1657f Michael Chan 2018-09-14 @1249  int bnxt_approve_mac(struct bnxt *bp, u8 *mac, bool strict)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]