From: Florian Westphal <fw@strlen•de>
To: "Maciej Żenczykowski" <zenczykowski@gmail•com>
Cc: Florian Westphal <fw@strlen•de>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Linux Network Development Mailing List <netdev@vger•kernel.org>,
Netfilter Development Mailing List
<netfilter-devel@vger•kernel.org>
Subject: Re: [PATCH netfilter] netfilter: conntrack: udp: generate event on switch to stream timeout
Date: Fri, 15 Oct 2021 12:50:46 +0200 [thread overview]
Message-ID: <20211015105046.GI2942@breakpoint.cc> (raw)
In-Reply-To: <CAHo-OoxsN5d+ipbp0TQ=a+o=ynd3-w5RZ3S3F8Vg89ipT5=UHw@mail.gmail.com>
Maciej Żenczykowski <zenczykowski@gmail•com> wrote:
> On Fri, Oct 15, 2021 at 2:57 AM Florian Westphal <fw@strlen•de> wrote:
> > Do you think it makes sense to just delay setting the ASSURED bit
> > until after the 2s period?
>
> That would work for this particular use case.... but I don't know if
> it's a good idea.
> I did of course think of it, but the commit message seemed to imply
> there's a good reason to set the assured bit earlier rather than
> later...
>
> A udp flow becoming bidirectional seems like an important event to
> notify about...
> Afterall, the UDP flow might become a stream 29 seconds after it
> becomes bidirectional...
Oh right, never mind then.
Acked-by: Florian Westphal <fw@strlen•de>
next prev parent reply other threads:[~2021-10-15 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 9:09 [PATCH netfilter] netfilter: conntrack: udp: generate event on switch to stream timeout Maciej Żenczykowski
2021-10-15 9:30 ` Pablo Neira Ayuso
2021-10-15 9:50 ` Maciej Żenczykowski
2021-10-15 9:57 ` Florian Westphal
2021-10-15 10:15 ` Maciej Żenczykowski
2021-10-15 10:50 ` Florian Westphal [this message]
2021-10-17 22:04 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015105046.GI2942@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=zenczykowski@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox