From: Wong Vee Khee <vee.khee.wong@linux•intel.com>
To: Kurt Kanzenbach <kurt@linutronix•de>
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Jose Abreu <joabreu@synopsys•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Fugang Duan <fugang.duan@nxp•com>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Ong Boon Leong <boon.leong.ong@intel•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH net] net: stmmac: Fix E2E delay mechanism
Date: Thu, 21 Oct 2021 14:44:38 +0800 [thread overview]
Message-ID: <20211021064438.GA11169@linux.intel.com> (raw)
In-Reply-To: <20211020070433.71398-1-kurt@linutronix.de>
On Wed, Oct 20, 2021 at 09:04:33AM +0200, Kurt Kanzenbach wrote:
> When utilizing End to End delay mechanism, the following error messages show up:
>
> |root@ehl1:~# ptp4l --tx_timestamp_timeout=50 -H -i eno2 -E -m
> |ptp4l[950.573]: selected /dev/ptp3 as PTP clock
> |ptp4l[950.586]: port 1: INITIALIZING to LISTENING on INIT_COMPLETE
> |ptp4l[950.586]: port 0: INITIALIZING to LISTENING on INIT_COMPLETE
> |ptp4l[952.879]: port 1: new foreign master 001395.fffe.4897b4-1
> |ptp4l[956.879]: selected best master clock 001395.fffe.4897b4
> |ptp4l[956.879]: port 1: assuming the grand master role
> |ptp4l[956.879]: port 1: LISTENING to GRAND_MASTER on RS_GRAND_MASTER
> |ptp4l[962.017]: port 1: received DELAY_REQ without timestamp
> |ptp4l[962.273]: port 1: received DELAY_REQ without timestamp
> |ptp4l[963.090]: port 1: received DELAY_REQ without timestamp
>
> Commit f2fb6b6275eb ("net: stmmac: enable timestamp snapshot for required PTP
> packets in dwmac v5.10a") already addresses this problem for the dwmac
> v5.10. However, same holds true for all dwmacs above version v4.10. Correct the
> check accordingly. Afterwards everything works as expected.
>
> Tested on Intel Atom(R) x6414RE Processor.
>
> Fixes: 14f347334bf2 ("net: stmmac: Correctly take timestamp for PTPv2")
> Fixes: f2fb6b6275eb ("net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a")
> Suggested-by: Ong Boon Leong <boon.leong.ong@intel•com>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix•de>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index eb3b7bf771d7..3d67d1fa3690 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -736,7 +736,7 @@ static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr)
> config.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;
> ptp_v2 = PTP_TCR_TSVER2ENA;
> snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
> - if (priv->synopsys_id != DWMAC_CORE_5_10)
> + if (priv->synopsys_id < DWMAC_CORE_4_10)
> ts_event_en = PTP_TCR_TSEVNTENA;
> ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
> ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
This fixes PTPv2 E2E issue on EHL-based boards. Can this also
be applied to 5.4 and onwards?
Thanks,
Vee Khee
next prev parent reply other threads:[~2021-10-21 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 7:04 [PATCH net] net: stmmac: Fix E2E delay mechanism Kurt Kanzenbach
2021-10-20 13:50 ` patchwork-bot+netdevbpf
2021-10-21 6:44 ` Wong Vee Khee [this message]
2021-10-21 6:55 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021064438.GA11169@linux.intel.com \
--to=vee.khee.wong@linux$(echo .)intel.com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=boon.leong.ong@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fugang.duan@nxp$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox