From: Arnd Bergmann <arnd@kernel•org>
To: Johannes Berg <johannes.berg@intel•com>
Cc: Arnd Bergmann <arnd@arndb•de>,
Luca Coelho <luciano.coelho@intel•com>,
Kalle Valo <kvalo@codeaurora•org>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Nathan Chancellor <nathan@kernel•org>,
Nick Desaulniers <ndesaulniers@google•com>,
Yaara Baruch <yaara.baruch@intel•com>,
Matti Gottlieb <matti.gottlieb@intel•com>,
Emmanuel Grumbach <emmanuel.grumbach@intel•com>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, llvm@lists•linux.dev
Subject: [PATCH] iwlwifi: pcie: fix constant-conversion warning
Date: Fri, 29 Oct 2021 17:42:29 +0200 [thread overview]
Message-ID: <20211029154253.3824677-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb•de>
clang points out a potential issue with integer overflow when
the iwl_dev_info_table[] array is empty:
drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1344:42: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion]
for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
This is still harmless, as the loop correctly terminates, but adding
an (int) cast makes that clearer to the compiler.
Fixes: 3f7320428fa4 ("iwlwifi: pcie: simplify iwl_pci_find_dev_info()")
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index c574f041f096..81e8f2fc4982 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -1341,7 +1341,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
{
int i;
- for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
+ for (i = (int)ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
if (dev_info->device != (u16)IWL_CFG_ANY &&
--
2.29.2
next reply other threads:[~2021-10-29 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 15:42 Arnd Bergmann [this message]
2021-10-31 7:06 ` [PATCH] iwlwifi: pcie: fix constant-conversion warning Kalle Valo
2021-11-01 7:29 ` Coelho, Luciano
2021-11-01 7:32 ` Coelho, Luciano
-- strict thread matches above, loose matches on Subject: below --
2021-11-04 13:37 Arnd Bergmann
2021-11-10 21:38 ` Nick Desaulniers
2021-11-10 21:39 ` Nick Desaulniers
2021-11-11 7:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029154253.3824677-1-arnd@kernel.org \
--to=arnd@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=emmanuel.grumbach@intel$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=luciano.coelho@intel$(echo .)com \
--cc=matti.gottlieb@intel$(echo .)com \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yaara.baruch@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox